Update Error Docs - #14917
Open
phpstan-bot wants to merge 1 commit into
Open
Conversation
- Removed `website/errors/parameter.void.md` after the identifier was dropped from `errorsIdentifiers.json` - The `parameter.void` rule was removed from phpstan-src (commit c473981, "Fix build after upgrading to PHP-Parser 5.8.0") because PHP-Parser 5.8.0 now rejects `void` as a parameter type at parse time - All other diff changes were only source line-number shifts, requiring no documentation updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest
website/src/errorsIdentifiers.jsonupdate removed theparameter.voididentifier.Investigating the diff showed this was the only meaningful change — every other entry in the diff was just a source line-number shift caused by the PHP-Parser 5.8.0 upgrade, with no rule-class or identifier changes.
The
parameter.voidrule was removed from phpstan-src in commitc473981("Fix build after upgrading to PHP-Parser 5.8.0"). PHP-Parser 5.8.0 now rejectsvoidused as a parameter type at parse time, so PHPStan no longer needs a dedicated rule/identifier for it.Changes
website/errors/parameter.void.md, since the identifier no longer exists inerrorsIdentifiers.jsonand is no longer produced by any rule.After the change, the error docs are fully in sync with the identifier list: no identifiers are missing a
.mdfile, and no orphaned.mdfiles remain.