gh-123059: Document archive timestamp timezone handling - #155195
Open
JasonColapietro wants to merge 1 commit into
Open
gh-123059: Document archive timestamp timezone handling#155195JasonColapietro wants to merge 1 commit into
JasonColapietro wants to merge 1 commit into
Conversation
|
All commit authors signed the Contributor License Agreement. |
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #123059.
This documents the different timestamp behavior used when adding filesystem entries to ZIP and tar archives:
ZipFile.write()converts the filesystem modification time to the current local time, which can make otherwise identical archives differ across time zones. The docs now show how to supply an explicitZipInfo.date_timewithwritestr()when the timestamp must be controlled.TarFile.add()stores the modification time as epoch seconds without a local-time conversion, while noting that filesystem-provided timestamps may still be time-zone-dependent.Checks:
sphinx-lintonDoc/library/zipfile.rstandDoc/library/tarfile.rstgit diff --checkDeveloped with help from Codex. I reviewed and understand the change.
zipfileandtarfiledocs should cover local timezone impact on entry timestamps #123059