Add close keymaps to commit log panel - #482
Draft
kevintraver wants to merge 2 commits into
Draft
Conversation
kevintraver
force-pushed
the
feature/close-keymaps-for-commit-log-panel
branch
from
April 4, 2024 18:01
32e7f98 to
d2659c4
Compare
|
What's needed to get this done? I can make a PR if needed. |
Contributor
|
i think the author addressed that in #167 (comment) |
dlyongemallo
pushed a commit
to dlyongemallo/diffview-plus.nvim
that referenced
this pull request
Feb 4, 2026
Add q and <esc> keymaps to close the commit log panel, matching the behaviour of other panels like the help panel. The keymaps are configurable via keymaps.commit_log_panel. Fixes sindrets#481
dlyongemallo
reviewed
Feb 5, 2026
|
|
||
| for _, mapping in ipairs(conf.commit_log_panel) do | ||
| local map_opt = vim.tbl_extend("force", default_opt, mapping[4] or {}, { buffer = self.bufid }) | ||
| vim.keymap.set(mapping[1], mapping[2], mapping[3], map_opt) |
There was a problem hiding this comment.
I think this is incorrect. It sets a global keymap which means pressing Escape will now close any diffview window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress for #481