Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Config Dynamic Property Wrapper #10155

Merged
merged 44 commits into from
Sep 23, 2022
Merged

Remote Config Dynamic Property Wrapper #10155

merged 44 commits into from
Sep 23, 2022

Conversation

charlotteliang
Copy link
Contributor

@charlotteliang charlotteliang commented Aug 31, 2022

Added the new API that enables developers to define a property wrapper that listens to a remote config key value. When remote config is activated, the UI component will automatically reflect the activated value.

@google-oss-bot
Copy link

google-oss-bot commented Aug 31, 2022

Coverage Report 1

Affected Products

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    Overall coverage changed from 79.58% (a97a5be) to 79.62% (9da2d37) by +0.04%.

    FilenameBase (a97a5be)Merge (9da2d37)Diff
    FIRRemoteConfig.m83.61%83.74%+0.14%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/akkNyVpouv.html

Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had a few small comments.

@charlotteliang
Copy link
Contributor Author

Ignore the test failure since it's something we need to fix in the infra.

@charlotteliang charlotteliang self-assigned this Sep 20, 2022
@ncooke3
Copy link
Member

ncooke3 commented Sep 21, 2022

Hi @chliangGoogle, I re-ran 40804aa's CI and PTAL at the results here:
https://github.com/firebase/firebase-ios-sdk/actions/runs/3084312372/jobs/5019355333

The 429 errors are gone, but there are 4 failures. Are these the failures you've been seeing?

@charlotteliang
Copy link
Contributor Author

@ncooke3 yeah these are the same failure we've seen and we've run them successfully locally.

FirebaseRemoteConfigSwift/CHANGELOG.md Outdated Show resolved Hide resolved
… the config data in api test that affecting the results to be inaccurate
@charlotteliang charlotteliang merged commit f804aba into master Sep 23, 2022
@charlotteliang charlotteliang deleted the char-rc-pw branch September 23, 2022 03:01
ncooke3 added a commit that referenced this pull request Sep 24, 2022
* [Firebase 10] Bump 9.X versions to 10.0.0

* Bump min. GTMSessionFetcher dep version to 2.1

* Bump min. GDT dep version to 9.2

* Bump min. GULs dep version to 7.8

* Fix unintentional nanopb replace

* Fix unintentional nanopb replace (2)

* Fix unintentional nanopb replace (3)

* Fix unintentional nanopb replace (4)

* Fix unintentional nanopb replace (4)

* Trigger all CI

* Bump FirebaseCombineSwift to 10

* Fix FirebaseStorage.podspec
I'm not sure what happened here. I had committed it during the rebase but guess not?

* Fix unintentional nanopb replace (5)

* Disable two tests to unblock staging

* Fix and re-enable FIROptions tests

* Update deployment targets in Firebase.podspec

* Add CHANGELOG entry for GTMSessionFetcher

* Fix AppCheck iOS availability

* Fix inadvertent API change (#10245)

* Docs update for Extensions and putFile (#10248)

* App google domain support (#10249)

Adding new 1p domain "app.google" support in FDL SDK.

* Remote Config Dynamic Property Wrapper (#10155)

* Separate GoogleUtilities Carthage build (#10250)

* Public count (#10246)

* Public Count

* Swift Test Commit

* Swift Format

* No extra whitespace

* Hopefully formatted.

* Change log and feedback.

* Revert "Public count (#10246)" (#10252)

This reverts commit 8aae6be.

* Make Firestore use FirebaseDataEncoder and FirebaseDataDecoder (re-implementation of #8858) (#9465)

* Bump tvOS minimum support version to 12.0

* [skip ci] Revert Gemfile

Co-authored-by: Paul Beusterien <paulbeusterien@google.com>
Co-authored-by: Eldhose M Babu <eldhosembabu@google.com>
Co-authored-by: Charlotte Liang <chliang@google.com>
Co-authored-by: wu-hui <53845758+wu-hui@users.noreply.github.com>
Co-authored-by: Morten Bek Ditlevsen <bek@termestrup.dk>
@firebase firebase locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy