Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Fix FAILED_PRECONDITION when writing to a deleted document in a transaction #10431

Merged
merged 20 commits into from
Nov 3, 2022
Merged

Firestore: Fix FAILED_PRECONDITION when writing to a deleted document in a transaction #10431

merged 20 commits into from
Nov 3, 2022

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Nov 1, 2022 •
edited
Loading

This PR ports firebase/firebase-js-sdk#6550, and its follow-up PR firebase/firebase-js-sdk#6729. A similar port to the Android SDK was done in firebase/firebase-android-sdk#4257.

@dconeybe dconeybe self-assigned this Nov 1, 2022
@google-oss-bot
Copy link

google-oss-bot commented Nov 1, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.25% (ec7ab4b) to 88.19% (36cbf6d) by -0.05%.

    FilenameBase (ec7ab4b)Merge (36cbf6d)Diff
    exception.cc84.21%23.68%-60.53%
    exception_apple.mm65.52%96.55%+31.03%
    leveldb_key.cc98.63%98.82%+0.20%
    ordered_code.cc94.39%93.90%-0.49%
    task.cc93.91%94.78%+0.87%
    transaction.cc89.81%90.06%+0.25%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jMsJlhpcS2.html

@dconeybe dconeybe changed the base branch from master to dconeybe/NanopPbPython311Fix November 1, 2022 22:54
Base automatically changed from dconeybe/NanopPbPython311Fix to master November 2, 2022 02:54
@dconeybe dconeybe marked this pull request as ready for review November 2, 2022 16:30
milaGGL
milaGGL reviewed Nov 2, 2022
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can understand, the bug fix logic is in sync with web and android SDK.

milaGGL
milaGGL previously approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milaGGL milaGGL dismissed their stale review November 2, 2022 19:23

Needs more reviews

@dconeybe dconeybe requested a review from wu-hui November 3, 2022 14:02
wu-hui
wu-hui approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dconeybe dconeybe merged commit e9ba9eb into master Nov 3, 2022
@dconeybe dconeybe deleted the dconeybe/TransactionWriteToDeletedDocFix branch November 3, 2022 19:02
visumickey pushed a commit that referenced this pull request Nov 9, 2022
@dconeybe @visumickey
Firestore: Fix FAILED_PRECONDITION when writing to a deleted document…
7766823 
… in a transaction (#10431)
@dconeybe
Copy link
Contributor Author

FYI This fix has been incorporated into version 10.2.0 released November 15, 2022 https://firebase.google.com/support/release-notes/ios#version_1020_-_november_15_2022

@firebase firebase locked and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

@milaGGL milaGGL milaGGL left review comments

Assignees

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dconeybe @google-oss-bot @wu-hui @milaGGL
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy