Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firestore] Add warning when building Firestore's binary SPM distro for visionOS #12279

Merged
merged 8 commits into from
Jan 16, 2024
Merged

[Firestore] Add warning when building Firestore's binary SPM distro for visionOS #12279

merged 8 commits into from
Jan 16, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 16, 2024 •
edited
Loading

The proposed consists of two parts:

  1. Change the Package.swift to only build Firestore's binary targets on platforms that support the binary distribution (e.g. !visionOS)
    • This shifts the problem from the package loading phase to the compilation phase.
  2. Add a warning in the source wrapper target to issue a warning only on visionOS and only when it is detected that the client is using the binary distro*.
    • *: We can determine this by configuring the wrapper target in the binary distro code path to define a preprocessor directive.

@google-oss-bot
Copy link

google-oss-bot commented Jan 16, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.10% (795c800) to 88.17% (a36fd8b) by +0.06%.

    FilenameBase (795c800)Merge (a36fd8b)Diff
    exception.cc23.68%84.21%+60.53%
    leveldb_key.cc98.82%98.33%-0.49%
    ordered_code.cc94.39%93.90%-0.49%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0OlvLiNKHk.html

andrewheard
andrewheard approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nick!

Firestore/CHANGELOG.md Outdated Show resolved Hide resolved
@ncooke3 ncooke3 enabled auto-merge (squash) January 16, 2024 16:28
@ncooke3 ncooke3 disabled auto-merge January 16, 2024 18:43
@ncooke3 ncooke3 merged commit 756b5a4 into main Jan 16, 2024
65 of 66 checks passed
@ncooke3 ncooke3 deleted the nc/visionos-binary-warning branch January 16, 2024 18:48
@ncooke3 ncooke3 mentioned this pull request Jan 16, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@peterfriese peterfriese peterfriese approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ncooke3 @google-oss-bot @paulb777 @peterfriese @andrewheard
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy