Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Refactor BlockReason as a struct and add new values #13861

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Oct 9, 2024

Replaced the BlockReason enum with a struct to prevent breaking changes when new values are added (since switch statements must be exhaustively checked in Swift). Added the new values blocklist and prohibitedContent.

@andrewheard andrewheard added this to the 11.4.0 - M155 milestone Oct 9, 2024
@andrewheard andrewheard force-pushed the ah/vertex-blockreason branch from aaa9ef9 to 67ba3a5 Compare October 9, 2024 22:35
@andrewheard andrewheard marked this pull request as ready for review October 9, 2024 22:42
@andrewheard andrewheard requested a review from paulb777 October 9, 2024 22:42
@andrewheard andrewheard merged commit 4b263b6 into main Oct 9, 2024
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-blockreason branch October 9, 2024 22:53
MojtabaHs pushed a commit to MojtabaHs/firebase-ios-sdk that referenced this pull request Oct 17, 2024
@firebase firebase locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy