Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIAM init(actionText:actionURL:)' is deprecated #3545

Closed
xuaninbox opened this issue Aug 9, 2019 · 3 comments
Closed

FIAM init(actionText:actionURL:)' is deprecated #3545

xuaninbox opened this issue Aug 9, 2019 · 3 comments
Assignees
@christibbs
Labels
api: inappmessaging Firebase In App Messaging
Milestone
6.8.0

Comments

@xuaninbox
Copy link

xuaninbox commented Aug 9, 2019 •
edited
Loading

  • Xcode version: 10.3
  • Firebase SDK version: 6.6
  • Firebase Component: FirebaseInAppMessaging
  • Component version: 0.15.3

[REQUIRED] Step 3: Describe the problem

When using

InAppMessagingAction(actionText: modalMessage.actionButton?.buttonText, actionURL: actionURL)

warning says it's deprecated, I'm using customs InAppMessagingDisplay and I can't seem to find any replacement for this. Whats the best approach to fix this issue.
@google-oss-bot

This comment has been minimized.

Sign in to view
@morganchen12 morganchen12 added api: inappmessaging Firebase In App Messaging and removed needs-triage labels Aug 9, 2019
@christibbs
Copy link
Contributor

Hey Xuan, when we deprecated the initializer for InAppMessagingAction we failed to consider the custom InAppMessagingDisplay case. We'll un-deprecate it with the next release.

@paulb777
Copy link
Member

@christibbs Let's leave the issue open and close it with the PR that does the un-deprecation.

@paulb777 paulb777 reopened this Aug 15, 2019
@paulb777 paulb777 added this to the M55 milestone Aug 15, 2019
@christibbs christibbs mentioned this issue Aug 22, 2019
Merged
@xuaninbox xuaninbox mentioned this issue Sep 27, 2019
Closed
@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christibbs christibbs

Labels
api: inappmessaging Firebase In App Messaging
Projects
None yet
Milestone
6.8.0
Development

No branches or pull requests
5 participants
@paulb777 @morganchen12 @xuaninbox @google-oss-bot @christibbs
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy