Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Carthage] Some frameworks are missing Info.plist files and fail installation in Simulator #5562

Closed
daltonclaybrook opened this issue May 11, 2020 · 7 comments · Fixed by #6445
Closed

[Carthage] Some frameworks are missing Info.plist files and fail installation in Simulator #5562

daltonclaybrook opened this issue May 11, 2020 · 7 comments · Fixed by #6445
Assignees
@paulb777
Labels
Carthage zip-builder Tools related to building the zip file.
Milestone
6.33.0 - М80

Comments

@daltonclaybrook
Copy link

daltonclaybrook commented May 11, 2020 •
edited
Loading

[REQUIRED] Step 1: Describe your environment

  • Xcode version: Xcode 11.4.1 (11E503a)
  • Firebase SDK version: Latest Carthage binary
  • Firebase Component: Analytics
  • Component version: Latest Carthage binary
  • Installation method: Carthage

[REQUIRED] Step 2: Describe the problem

I'm attempting to use the Firebase Analytics framework using Carthage, but when I attempt to run the app on the simulator with this framework and dependent frameworks included in the bundle, I receive the following error in Xcode:

Failed to load Info.plist from bundle at path /Users/daltonclaybrook/Library/Developer/CoreSimulator/Devices/506C25EF-1588-4AA5-A19A-79D71FE85875/data/Library/Caches/com.apple.mobile.installd.staging/temp.1Fh1ur/extracted/Payload/Argon.app/Frameworks/GoogleAppMeasurement.framework
Failed to load Info.plist from bundle at path /Users/daltonclaybrook/Library/Developer/CoreSimulator/Devices/506C25EF-1588-4AA5-A19A-79D71FE85875/data/Library/Caches/com.apple.mobile.installd.staging/temp.1Fh1ur/extracted/Payload/Argon.app/Frameworks/GoogleAppMeasurement.framework

Upon inspection of the framework in the Carthage builds folder, it is clear that this framework does not contain an Info.plist. As a test, I manually created an Info.plist for this framework and received the error again for FIRAnalyticsConnector and FirebaseAnalytics. Once I created Info.plists for all three frameworks, the build seems to install correctly.

Steps to reproduce:

  1. Make a new app and install the Firebase Analytics framework and all dependencies using Carthage.
  2. Run the app on the simulator.
  3. App fails to install in simulator with the above errors
@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@paulb777 paulb777 self-assigned this May 11, 2020
@paulb777 paulb777 added this to the 6.25.0 - M71 milestone May 11, 2020
@paulb777
Copy link
Member

Thanks for the report.

I see the issue of the missing Info.plist files, but I'm able to start in the simulator without a problem. Make sure they're NOT included in the Carthage copy-frameworks Build Phase.

Anyway, I'll take a look at including them in the next release.

@paulb777 paulb777 removed this from the 6.25.0 - M71 milestone May 11, 2020
@paulb777
Copy link
Member

It seems this has existed for several releases and seems to be mostly innocuous. Since there is a relatively easy workaround, I'm not going to prioritize for the next release.

@daltonclaybrook
Copy link
Author

Thanks for the quick reply @paulb777. You're right, I had erroneously included these frameworks in the copy-frameworks phase. Removing them fixed my issue.

@paulb777 paulb777 added the zip-builder Tools related to building the zip file. label May 11, 2020
@paulb777
Copy link
Member

Great! I'll leave this issue open to add back the Info.plist files.

@KC-218
Copy link

KC-218 commented Jul 9, 2020

Sorry, I met the same question, how to create these info.plist.
And what the plist content look like?

@paulb777
Copy link
Member

paulb777 commented Jul 9, 2020

@Bruce9487 The solution is to make sure the Firebase frameworks are not in the copy-frameworks phase.

@paulb777 paulb777 mentioned this issue Aug 31, 2020
Closed
@paulb777 paulb777 added this to the 6.33.0 - М80 milestone Sep 11, 2020
@paulb777 paulb777 mentioned this issue Sep 11, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paulb777 paulb777

Labels
Carthage zip-builder Tools related to building the zip file.
Projects
None yet
Milestone
6.33.0 - М80
Development

Successfully merging a pull request may close this issue.

Add Info.plist to Carthage binary frameworks firebase/firebase-ios-sdk
4 participants
@paulb777 @daltonclaybrook @KC-218 @google-oss-bot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy