Fixing unwanted pending dynamic links checks on subsequent app restarts #5665
Conversation
Most of the times, when the app is cold started, we are making api calls to: https://firebasedynamiclinks-ipv4.googleapis.com/v1 https://firebasedynamiclinks-ipv6.googleapis.com/v1 Until we get a successful response. But sometimes, if the device doesn’t have support for v6 endpoint and if the v4 endpoint doesn’t retrieve a valid dynamic link, it will return error. This mostly happens when user directly goes to App Store and installs an app which has fdl sdk integrated. For dynamic links, we want the app to retrieve the pending dynamic link on the very first start of the app after install so that 3p developers can deeplink to a particular page in the app. If the pending links retrieval failed during the first start, there is no point in retrying the retrieval during next restart since it could result in an un expected deep link for the user when they opens up the app for subsequent restarts (if a valid dynamic link is returned).
There was a problem hiding this comment.
Thanks for the PR @eldhosembabu!
Please investigate adding a unit test.
Please fix the GHA issues by running clang-format. See https://github.com/firebase/firebase-ios-sdk#code-formatting
While ok to put internal bug numbers in PRs, it should not be in the title. Instead a short description of the bug fix should be there.
Also the PR description should include a note about the GitHub issue being fixed. With "Fix #{bug number}", GitHub will automatically close the related bug when the PR merges.
|
There was a problem hiding this comment.
Thanks for the followup!
I thought this was also a fix for #5032?
The description looks good. Please also add it to https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseDynamicLinks/CHANGELOG.md. The version can be "Unreleased" for now.
Plus three more spelling nits
|
Fix for b/154589338
Most of the times, when the app is cold started, we are making api calls to:
https://firebasedynamiclinks-ipv4.googleapis.com/v1
https://firebasedynamiclinks-ipv6.googleapis.com/v1
Until we get a successful response. But sometimes, if the device doesn’t have support for v6 endpoint and if the v4 endpoint doesn’t retrieve a valid dynamic link, it will return error. This mostly happens when user directly goes to App Store and installs an app which has fdl sdk integrated.
For dynamic links, we want the app to retrieve the pending dynamic link on the very first start of the app after install so that 3p developers can deeplink to a particular page in the app. If the pending links retrieval failed during the first start, there is no point in retrying the retrieval during next restart since it could result in an un expected deep link for the user when they opens up the app for subsequent restarts (if a valid dynamic link is returned).