Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RTDB Query get #7110

Merged
merged 17 commits into from
Jan 6, 2021
Merged

Implement RTDB Query get #7110

merged 17 commits into from
Jan 6, 2021

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented Dec 5, 2020

Discussion

#7109

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

go/rtdb-get

@google-cla google-cla bot added the cla: yes label Dec 5, 2020
@jmwski jmwski assigned jmwski and unassigned schmidt-sebastian Dec 7, 2020
@jmwski jmwski assigned schmidt-sebastian and unassigned jmwski Dec 8, 2020
schmidt-sebastian
schmidt-sebastian reviewed Dec 8, 2020
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty impressive. This looks great! Some feedback, but nothing major.

FirebaseDatabase/CHANGELOG.md Outdated Show resolved Hide resolved
FirebaseDatabase/Sources/Api/FIRDatabaseQuery.m Show resolved Hide resolved
FirebaseDatabase/Sources/Constants/FConstants.m Outdated Show resolved Hide resolved
FirebaseDatabase/Sources/Core/FPersistentConnection.m Show resolved Hide resolved
FirebaseDatabase/Sources/Core/FPersistentConnection.m Show resolved Hide resolved
FirebaseDatabase/Sources/Core/FPersistentConnection.m Outdated Show resolved Hide resolved
FirebaseDatabase/Sources/Core/FPersistentConnection.m Outdated Show resolved Hide resolved
FirebaseDatabase/Tests/Integration/FIRDatabaseQueryTests.m Outdated Show resolved Hide resolved
FirebaseDatabase/Sources/Core/FRepo.m Outdated Show resolved Hide resolved
FirebaseDatabase/Tests/Integration/FIRDatabaseQueryTests.m Show resolved Hide resolved
@jmwski jmwski assigned schmidt-sebastian and unassigned jmwski Dec 16, 2020
@jmwski jmwski assigned schmidt-sebastian and unassigned jmwski Dec 17, 2020
schmidt-sebastian
schmidt-sebastian approved these changes Dec 17, 2020
View reviewed changes
FirebaseDatabase/CHANGELOG.md Outdated Show resolved Hide resolved
@jmwski jmwski merged commit 55f27b5 into master Jan 6, 2021
@jmwski jmwski deleted the jw/rtdb-query-get branch January 6, 2021 01:07
paulb777 added a commit that referenced this pull request Jan 7, 2021
@paulb777
Revert "Implement RTDB Query get (#7110)"
66e09dd 
This reverts commit 55f27b5.
This was referenced Jan 7, 2021
Merged
Closed
paulb777 added a commit that referenced this pull request Jan 7, 2021
@paulb777
Revert "Implement RTDB Query get (#7110)" (#7262)
f8c6459 
This reverts commit 55f27b5.
@firebase firebase locked and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson left review comments

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@jmwski jmwski

Labels
api: database cla: yes public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmwski @ryanwilson @schmidt-sebastian @google-oss-bot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy