Merge IID removal code to master #7814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
|
paulb777
reviewed
Mar 31, 2021
FirebaseMessaging.podspec
Outdated
| @@ -42,7 +42,7 @@ device, and it is completely free. | |||
| 'Firebase/InstanceID/Public/*.h', | |||
| 'FirebaseInstallations/Source/Library/Private/*.h', | |||
| ] | |||
| s.requires_arc = base_dir + 'Sources/*.m' | |||
| s.requires_arc = base_dir + 'Sources/**/*.m' | |||
There was a problem hiding this comment.
Now that protobuf's non-arc files are gone, this line could be deleted since requires_arc is the default
| s.dependency 'FirebaseInstanceID', '~> 7.0' | ||
| s.dependency 'FirebaseInstallations', '~> 7.0' | ||
| s.dependency 'FirebaseCore', '~> 7.0' |
FirebaseMessaging/CHANGELOG.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| #unreleased | |||
| FOUNDATION_EXPORT const int kFIRMessagingSendTtlDefault; // 24 hours | ||
|
|
||
| /** | ||
| * Value included in a structured response or GCM message from IID, indicating |
There was a problem hiding this comment.
Is it still called IID when it's integrated in FCM?
There was a problem hiding this comment.
The description doesn't make sense. I updated. But yeah FM code-wise should not depend on IID. But might still handle some signals sending from IID in case users still use IID.
charlotteliang
commented
Mar 31, 2021
| FOUNDATION_EXPORT const int kFIRMessagingSendTtlDefault; // 24 hours | ||
|
|
||
| /** | ||
| * Value included in a structured response or GCM message from IID, indicating |
There was a problem hiding this comment.
The description doesn't make sense. I updated. But yeah FM code-wise should not depend on IID. But might still handle some signals sending from IID in case users still use IID.
| s.dependency 'FirebaseInstanceID', '~> 7.0' | ||
| s.dependency 'FirebaseInstallations', '~> 7.0' | ||
| s.dependency 'FirebaseCore', '~> 7.0' |
maksymmalyhin
approved these changes
Mar 31, 2021
paulb777
approved these changes
Mar 31, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chen/fm-master branch contains all the changes required to remove IID from Messaging.
The code change is targeting in M94 that will not include the part we remove the IID dependency in podspec. We will remove the dependency at the I/O breaking change.