Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Analytics SwiftPM platform availability. #9032

Merged
merged 5 commits into from
Nov 30, 2021
Merged

Conversation

ryanwilson
Copy link
Member

For some reason this still works in a project, but Xcode gets confused
and doesn't autocomplete the module appropriately. This should fix it
for tvOS and macOS.

Also cleaned up a few references to Analytics only being available on
iOS.

For some reason this still works in a project, but Xcode gets confused
and doesn't autocomplete the module appropriately. This should fix it
for tvOS and macOS.

Also cleaned up a few references to Analytics only being available on
iOS.
@google-cla google-cla bot added the cla: yes label Nov 30, 2021
.github/workflows/spm.yml Outdated Show resolved Hide resolved
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect Xcode and SPM don't communicate properly about xcframeworks.

thanks for investigating! Just a few comment nits and LGTM.

.github/workflows/spm.yml Outdated Show resolved Hide resolved
FirebaseCore/CHANGELOG.md Outdated Show resolved Hide resolved
@ryanwilson
Copy link
Member Author

Merging now, the last commit just had a word added to the CHANGELOG.

@ryanwilson ryanwilson merged commit 59cb44b into master Nov 30, 2021
@ryanwilson ryanwilson deleted the rw-analytics-swiftpm branch November 30, 2021 16:05
@firebase firebase locked and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy