Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct timezone proto key #3132

Merged
merged 1 commit into from
Jun 7, 2019
Merged

correct timezone proto key #3132

merged 1 commit into from
Jun 7, 2019

Conversation

charlotteliang
Copy link
Contributor

The timezone proto key passed in is in wrong format.

christibbs
christibbs approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@christibbs christibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Travis.

paulb777
paulb777 approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis was good except for a flake.

@charlotteliang charlotteliang merged commit f0f9d70 into master Jun 7, 2019
@charlotteliang charlotteliang deleted the fcm-timezone branch June 7, 2019 19:29
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christibbs christibbs christibbs approved these changes

@shrutip90 shrutip90 shrutip90 approved these changes

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@charlotteliang @paulb777 @maksymmalyhin @shrutip90 @christibbs @googlebot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy