Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2880 - generating email link from Admin SDK fails with Auth Emulator #2933

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

yuchenshi
Copy link
Member

Description

Fixes #2880.

Scenarios Tested

See tests added.

Sample Commands

N/A

@yuchenshi yuchenshi requested a review from sam-gc December 15, 2020 00:18
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Dec 15, 2020
@yuchenshi yuchenshi merged commit d3e1aab into master Dec 15, 2020
@yuchenshi yuchenshi deleted the ys/auth-email-link-admin branch December 15, 2020 19:42
bkendall added a commit that referenced this pull request Dec 15, 2020
* Fix #2880 - generating email link from Admin SDK fails with Auth Emulator (#2933)

* Fix #2880.

* Add changelog entry.

* fixes set-cookie issue (updated #2932) (#2939)

* Fixes #2931 - Support multiple Set-Cookie headers

apiv2.js uses node-fetch under the hood, which will concatenate duplicate headers with ', '. This is invalid for Set-Cookie headers.
The solution is to grab the raw headers (which will be an array) and call `res.setHeader()` with that value.

* add test

* changelog

Co-authored-by: Adam Ahmed <72171617+adam-remotesocial@users.noreply.github.com>

* 8.20.0

* [firebase-release] Removed change log and reset repo after 8.20.0 release

* auto fix audit issues

* force audit update major versions

* remove google-gax

Co-authored-by: Yuchen Shi <yuchenshi@google.com>
Co-authored-by: Adam Ahmed <72171617+adam-remotesocial@users.noreply.github.com>
Co-authored-by: Google Open Source Bot <firebase-oss-bot@google.com>
bkendall added a commit that referenced this pull request Dec 15, 2020
* Removing code to handle legacy functions (#2935)

* Disable Node.js 8 deploys for Cloud Functions. (#2934)

* drop testing and support for node 8 (#2620)

* remove/bump node 8s to node 10s

* update some dev dependencies

* update build target to es2017

* formatting

* upgrade mocha

* remove async types

* update check in binary to node 8

* Update package.json

* npm audit: breaking edition (#2941)

* Fix #2880 - generating email link from Admin SDK fails with Auth Emulator (#2933)

* Fix #2880.

* Add changelog entry.

* fixes set-cookie issue (updated #2932) (#2939)

* Fixes #2931 - Support multiple Set-Cookie headers

apiv2.js uses node-fetch under the hood, which will concatenate duplicate headers with ', '. This is invalid for Set-Cookie headers.
The solution is to grab the raw headers (which will be an array) and call `res.setHeader()` with that value.

* add test

* changelog

Co-authored-by: Adam Ahmed <72171617+adam-remotesocial@users.noreply.github.com>

* 8.20.0

* [firebase-release] Removed change log and reset repo after 8.20.0 release

* auto fix audit issues

* force audit update major versions

* remove google-gax

Co-authored-by: Yuchen Shi <yuchenshi@google.com>
Co-authored-by: Adam Ahmed <72171617+adam-remotesocial@users.noreply.github.com>
Co-authored-by: Google Open Source Bot <firebase-oss-bot@google.com>

Co-authored-by: joehan <joehanley@google.com>
Co-authored-by: Michael Bleigh <bleigh@google.com>
Co-authored-by: Yuchen Shi <yuchenshi@google.com>
Co-authored-by: Adam Ahmed <72171617+adam-remotesocial@users.noreply.github.com>
Co-authored-by: Google Open Source Bot <firebase-oss-bot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy