Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OOB flow to reset email when updateEmail is used. #3096

Merged
merged 18 commits into from
Feb 17, 2021

Conversation

ssbushi
Copy link
Contributor

@ssbushi ssbushi commented Jan 29, 2021

Description

Fixes #3070. Tests are pending. Drafting a PR to clarify a few things.

Scenarios Tested

Manually tested creating an account, updating email and using the oobLink to reset email.

Sample Commands

await firebase.auth().createUserWithEmailAndPassword('test@email.com', 'testing');
await firebase.auth().currentUser?.updateEmail('test1@email.com');

HTTP GET http://localhost:9099/emulator/v1/projects/project-test/oobCodes

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Jan 29, 2021
@ssbushi ssbushi requested a review from yuchenshi January 29, 2021 16:21
src/emulator/auth/operations.ts Outdated Show resolved Hide resolved
src/emulator/auth/operations.ts Outdated Show resolved Hide resolved
src/emulator/auth/operations.ts Outdated Show resolved Hide resolved
@ssbushi ssbushi requested a review from yuchenshi February 10, 2021 15:13
Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General approach LGTM. See blocking comments below and tests please.

src/emulator/auth/handlers.ts Outdated Show resolved Hide resolved
src/emulator/auth/handlers.ts Outdated Show resolved Hide resolved
src/emulator/auth/operations.ts Outdated Show resolved Hide resolved
src/emulator/auth/operations.ts Outdated Show resolved Hide resolved
src/emulator/auth/operations.ts Show resolved Hide resolved
src/emulator/auth/operations.ts Outdated Show resolved Hide resolved
src/emulator/auth/state.ts Outdated Show resolved Hide resolved
src/emulator/auth/operations.ts Show resolved Hide resolved
@ssbushi ssbushi requested review from yuchenshi and removed request for yuchenshi February 12, 2021 21:44
@ssbushi ssbushi marked this pull request as ready for review February 17, 2021 17:41
@ssbushi ssbushi requested a review from yuchenshi February 17, 2021 17:41
Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

src/emulator/auth/operations.ts Show resolved Hide resolved
src/emulator/auth/operations.ts Outdated Show resolved Hide resolved
src/emulator/auth/operations.ts Outdated Show resolved Hide resolved
src/emulator/auth/operations.ts Outdated Show resolved Hide resolved
@ssbushi ssbushi dismissed yuchenshi’s stale review February 17, 2021 18:45

Changes implemented

@ssbushi ssbushi requested a review from yuchenshi February 17, 2021 18:45
ssbushi and others added 2 commits February 17, 2021 13:46
Co-authored-by: Yuchen Shi <yuchenshi@google.com>
This was referenced Mar 12, 2021
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oobCode not appearing after updateEmail is called while using emulators
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy