Add support for setting user labels on scheduled functions #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
approved these changes
May 26, 2021
| @@ -227,7 +227,9 @@ export function addResourcesToBackend( | |||
| cloudFunction.trigger.eventFilters.resource = `${cloudFunction.trigger.eventFilters.resource}/${id}`; | |||
| } | |||
|
|
|||
| cloudFunction.labels = { "deployment-scheduled": "true" }; | |||
| cloudFunction.labels = Object.assign(cloudFunction.labels, { | |||
There was a problem hiding this comment.
Nit: now that we have object destructuring I personally find it cleaner to use that syntax:
cloudfunctions.labels = {
...cloudfunctions.lables,
"deployment-scheduled": true,
}Or at least I would if we wanted to create a copy of the dictionary. In this case, your code is equivalent to:
cloudFunction.labels["deployment-scheduled"] = true;There was a problem hiding this comment.
I prefer that too, so I'll switch this over. As is, this is not quite equivalent to cloudFunction.labels["deployment-scheduled"], because labels is optional & can be undefined. Object.assign safely handles that case, wheres the above does not.
There was a problem hiding this comment.
> obj = {}
{}
> obj.labels = Object.assign(obj.lables, {"foo": "bar"});
Uncaught TypeError: Cannot convert undefined or null to object
at Function.assign (<anonymous>)
Object splat supports undefined but Object.assign does not.
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
…3408) * add support for setting user labels on scheduled functions * Style change to use destructuring, and CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for user labels on scheduled functions.
Turns out we already supported user labels in this code path - except that they were being overwritten on scheduled functions.
Scenarios Tested
Confirmed that scheduled functions and non-scheduled functions are deployed with labels when firebase-functions passes them through.