-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not compile when integrate into my project #1139
Comments
@GHChrisSu What version of Gradle and the Android Gradle Plugin are you using? I recommend upgrading both to the latest. Are you using the Stripe Proguard rules? Are you attempting to reference that class in your code? What version of stripe-android did you upgrade from? |
@mshafrir I made my Gradle and Gradle plugin same with this project. Yes, I used the Proguard rules to my project, and I didn't reference the 3ds directly, and it's my first integrate.I just use the PaymentActivity code into my project, and use the version in Readme. For now I just use the source code and comment out the code about 3ds, and it's working temporarily |
@GHChrisSu what code did you comment out? Can you provide an example? |
@mshafrir-stripe A lot of I was commented out cause the error is in com.stripe.android.stripe3ds2 said Class A and a seems to be repetitive and I also use the kotlin to compile the code |
Same problem here with minify enabled :
My proguard config is Did you find any workaround? |
Hey @mshafrir-stripe, we are also facing this issue after trying to update the Stripe SDK to version 9.3.5. It seems like the Firebase Performance gradle plugin in combination with the case insensitive file system of MacOS is the root cause of this problem. As @droidluv mentioned here: #1141 (comment) the Firebase Performance plugin does some magic with the To reproduce, you could create a new "Basic Activity" project in Android Studio and change the created build.gradle files to these files: app/build.gradle:
top-level build.gradle:
Syncing and then building the project on a Mac should reproduce this issue. |
@j-koenig thanks for the repro steps! Specifying |
This should be fixed in stripe-android 9.3.6, which was just published |
@mshafrir-stripe I'm on the R8 team at Google. I think you might have been bitten by https://issuetracker.google.com/issues/129493704 I would love to make sure that we have actually fixed this issue. On the project where you disabled R8, would it be possible for you to enable R8 again and just check if the result contains class files in the same package both with lower-case and upper-case names? If that is the case, that could lead to these issues where unpacking the zip will lose classes and could probably lead to these errors. If that is the case, can you try using android studio 3.5 RC1 to check that this is no longer the case? In particular, if you still see both the lower-case and upper-case name of some class we would love to know so we can investigate. Sorry for the inconvenience. Let's work together on getting R8 reenabled for that dependency! :) |
@madsager I re-enabled R8 after upgrading to Android Studio 3.5 RC1 and verified using the Gradle config in #1139 (comment) - this seems to have resolved the issue. The change will go out in the next release. |
@madsager I just released stripe-android 10.0.1, which has R8 re-enabled |
@mshafrir-stripe Great! Thank for confirming that this did indeed resolve the issue! |
@madsager @msaffitz-stripe I am on Android Studio 3.5.2, Stripe SDK 12.2.0, firebase-perf 19.0.1, firebase:perf-plugin 1.3.1. I am still getting this error:
Can you please help? Thanks! |
@bhavinmdesai There was a bug in the Android Gradle Plugin which ended up not filtering out these module classes. This is http://issuetracker.google.com/issues/140290149. The fix should be in Android Studio 3.6 beta 2. Can you try that out and let me know if that works? If not, I'll open a separate bug so we can work with you to figure out what is going on. Thanks! |
@madsager Looks like that module-info.class error has been resolved but now getting the following error: Not sure if it is stripe related! |
@bhavinmdesai I do not think that is stripe related. Searching the issue tracker on our end I found this: http://issuetracker.google.com/issues/115556774 Which is marked as closed. Maybe you can post your setting (version of studio and android gradle plugin used) there so the team can have another look? Thanks for bringing this to our attention. |
@bhavinmdesai are you using BouncyCastle? |
No I am not.
But not sure if any other dependency is using it. I have a doubt on the AWS
SDK which I am using.
…On Wed 6 Nov, 2019, 5:27 PM Michael Shafrir, ***@***.***> wrote:
@bhavinmdesai <https://github.com/bhavinmdesai> are you using
BouncyCastle?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1139?email_source=notifications&email_token=ABTEDF5A6LU6NBKEQCAM6ADQSKWJ3A5CNFSM4H3E2L22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGJFSY#issuecomment-550277835>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTEDF6BHTYQYPL2QCHX6MLQSKWJ3ANCNFSM4H3E2L2Q>
.
|
for someone out there who's still experiencing the error, this might help |
Execution failed for task ':app:processDebugResources'.
ERROR:C:\Users\iambi.gradle\caches\transforms-3\e2f99c8e4772f871d3d9171f694e6881\transformed\jetified-paymentsheet-19.3.1\res\values\values.xml:146:5-165:13: AAPT: error: style attribute 'attr/cardForegroundColor (aka com.ugopro:attr/cardForegroundColor)' not found. ERROR:C:\Users\iambi.gradle\caches\transforms-3\e2f99c8e4772f871d3d9171f694e6881\transformed\jetified-paymentsheet-19.3.1\res\values\values.xml:192:5-196:13: AAPT: error: style attribute 'attr/colorOnSurface (aka com.ugopro:attr/colorOnSurface)' not found. ERROR:C:\Users\iambi.gradle\caches\transforms-3\e2f99c8e4772f871d3d9171f694e6881\transformed\jetified-paymentsheet-19.3.1\res\values\values.xml:205:5-215:13: AAPT: error: style attribute 'attr/colorSurface (aka com.ugopro:attr/colorSurface)' not found.
I have these error how to solve |
What gradle version are you using? You can find this by running './gradlew --version' on the command line. Also sometimes a rebuild or invalidating Android Studio caches will help. |
Thanks for replying , My issue was resolved. |
Error: Class content provided for type descriptor com.stripe.android.stripe3ds2.transaction.A actually defines class com.stripe.android.stripe3ds2.transaction.a
My android studio providing this error message to me, and I tried exclude com.stripe.android.stripe3ds2 but it not working at runtime stripe is depends on 3d secure.
In stripe3ds2 with class of name A and a, make me confuse
Installation method
SDK version
The text was updated successfully, but these errors were encountered: