feat(core): update task template and implement new plugin features

Ovidiu Barabula · Ovidiu Barabula · commit 012b1d8861d1 · 2018-03-31T15:06:17.000+03:00
support for custom configuration, plugin manager provides custom logger instance, removed plugable
from task file
diff --git a/src/tasks/task-init-project.ts b/src/tasks/task-init-project.ts
@@ -6,30 +6,53 @@
  */
 
 import * as gulp from 'gulp';
-import { Task } from '../task-manager';
-import PlugableTask from '../task-manager/plugable-task';
-import Logger from '../util/logger';
-import { AnyFunction } from '../util/utility-functions';
+import { PluginProvider } from '../plugin-manager/installable';
+import { AnyFunction, sleep } from '../util/utility-functions';
 
-const logger = Logger('frontvue')('init');
 
-// Task meta data
-const hook = 'init';
-const name = 'init-project';
-const description = 'Task for initializing a new project';
+// Configuration defaults
+const configDefaults = {
+  fullName: 'John Smith',
+  useDefault: true,
+};
+
+// Configuration wizard questions
+const questions = [
+  {
+    default: configDefaults.fullName,
+    message: 'Type in your full name',
+    name: 'fullName',
+    type: 'input',
+  },
+];
+
+// Object to be exported
+const taskExport = {
+  // configDefaults,
+  // configQuestionnaire: {
+  //   namespace: 'init',
+  //   questions,
+  // },
+  description: 'Task for initializing a new project',
+  hook: 'init',
+  name: 'init',
+  taskFn,
+};
 
 
 /**
  * Task main function
  * @param done Gulp async callback
  */
-function task(done?: AnyFunction): any {
-  logger.log(`Running Task: ${name}`);
+async function taskFn(done: AnyFunction, { logger }: PluginProvider): Promise<any> {
+  logger.debug('Something happening now...');
+  logger.debug('That something has been completed!');
   done && done();
 }
 
+
 /* test:start */
-export { task };
+export { taskFn };
 /* test:end */
 
-export default PlugableTask(task, hook, name, description);
+export default taskExport;
diff --git a/src/tasks/task-init-projects.spec.ts b/src/tasks/task-init-projects.spec.ts
@@ -1,20 +1,22 @@
 import { assert, expect } from 'chai';
 import 'mocha';
-import { task } from './task-init-project';
+import Logger from '../util/logger';
+import { AnyFunction } from '../util/utility-functions';
+import { taskFn } from './task-init-project';
 
 describe('#Task: Init project', () => {
+  const callback: AnyFunction = () => true;
+  const logger = Logger('frontvue')('init');
+
   it('does what it is supposed to do', () => {
-    expect(task()).to.not.throw;
+    expect(taskFn(callback, { logger })).to.not.throw;
   });
 
 
   it('calls the callback function', () => {
     let wasCalled = false;
-    const callback = () => wasCalled = true;
-    task(callback);
+    const customCallback = () => wasCalled = true;
+    taskFn(customCallback, { logger});
     expect(wasCalled).to.have.been.true;
   });
-
-
-  it('should be tested more');
 });
