feat(config): add destroy method to PackageJsonConfigReader

Ovidiu Barabula · Ovidiu Barabula · commit 0e6fc3c3c572 · 2018-03-12T20:07:16.000+02:00
diff --git a/src/config-manager/index.spec.ts b/src/config-manager/index.spec.ts
@@ -22,6 +22,11 @@ describe('ConfigManager', () => {
     const customReader: ConfigReaderFactory = (namespace: string) => {
       let config: Config = {};
       return {
+        destroy(): Promise<Config> {
+          const oldConfig = config;
+          delete config[namespace];
+          return Promise.resolve(oldConfig);
+        },
         fetch(): Promise<Config> {
           return Promise.resolve(config);
         },
diff --git a/src/config-manager/package-json-config-reader.spec.ts b/src/config-manager/package-json-config-reader.spec.ts
@@ -48,7 +48,9 @@ describe('PackageJsonConfigReader', () => {
 
   it('instantiates with no custom filepath', async () => {
     mockfs.restore();
-    const configReader = await PackageJsonConfigReader('frontvue');
+    expect(await PackageJsonConfigReader('frontvue'))
+      .to.be.an('object')
+      .to.have.all.keys('destroy', 'fetch', 'update');
   });
 
 
@@ -75,17 +77,23 @@ describe('PackageJsonConfigReader', () => {
   it('instantiates with prior Frontvue config object', async () => {
     const filepath = path.join(testDir, priorConfiguredFile);
     const configReader = await PackageJsonConfigReader('frontvue', filepath);
-    const config = await configReader.fetch();
-    expect(config).to.eql({ key: 'value' });
+    expect(await configReader.fetch()).to.eql({ key: 'value' });
   });
 
 
   it('updates config object', async () => {
     const filepath = path.join(testDir, noConfigFile);
     const configReader = await PackageJsonConfigReader('frontvue', filepath);
     const updated = await configReader.update({ key: 'value' });
-    const config = await configReader.fetch();
-    expect(config).to.eql({ key: 'value' });
+    expect(await configReader.fetch()).to.eql({ key: 'value' });
+  });
+
+
+  it('removes config from file and returns it', async () => {
+    const filepath = path.join(testDir, priorConfiguredFile);
+    const configReader = await PackageJsonConfigReader('frontvue', filepath);
+    expect(await configReader.destroy()).to.eql({ key: 'value' });
+    expect(await configReader.fetch()).to.be.undefined;
   });
 
 
diff --git a/src/config-manager/package-json-config-reader.ts b/src/config-manager/package-json-config-reader.ts
@@ -13,6 +13,7 @@ export interface Config {
 }
 
 export interface IConfigReader {
+  destroy(): Promise<Config>;
   fetch(): Promise<Config>;
   update(config: Config): Promise<boolean>;
 }
@@ -78,13 +79,29 @@ async function PackageJsonConfigReader(namespace: string, filepath?: string): Pr
     return updated;
   }
 
+
+  /**
+   * Remove configuration from file and return the removed config object
+   */
+  async function destroy(): Promise<Config> {
+    // Save existing config
+    const fileContent = await configFile.read();
+    // Delete config object
+    delete packageJson.config[namespace];
+    // Update the file
+    await configFile.write(packageJson);
+    return fileContent.config[namespace];
+  }
+
+
   // If no configuration object is found, initialize with an empty object
-  // if (!packageJson.hasOwnProperty('config') && !packageJson.config.hasOwnProperty(namespace)) {
   if (!hasNested(packageJson, `config.${namespace}`)) {
     await initializeEmptyConfig();
   }
 
+
   return Object.freeze({
+    destroy,
     fetch,
     update,
   });
