feat(core): improve task manager run method implementation

Ovidiu Barabula · Ovidiu Barabula · commit 38b2c04de481 · 2018-04-20T16:19:12.000+03:00
diff --git a/src/task-manager/index.ts b/src/task-manager/index.ts
@@ -54,16 +54,16 @@ function TaskManager(options?: TaskManagerOptions): TaskManager {
    * @param hook Name of the hook
    */
   function run(hook: string): Promise<boolean> {
-    return new Promise((resolve, reject) => {
-      const onError = (error?: Error) => reject(error || false);
-
-      if (hasTasks(hook)) {
-        gulp.parallel(tasks[hook])(onError);
-        return resolve(true);
-      }
-
+    // If not tasks in hook, return false
+    if (!hasTasks(hook)) {
       logger.warn(`<${hook}> hook doesn't exist or has no tasks`);
-      return resolve(false);
+      return Promise.resolve(false);
+    }
+
+    return new Promise((resolve, reject) => {
+      gulp.series(gulp.parallel(tasks[hook]), () => resolve(true))(
+        /* istanbul ignore next */ ignore => undefined,
+      );
     });
   }
 
