feat(core): load external plugins from project config

Ovidiu Barabula · Ovidiu Barabula · commit 91ded4f92bee · 2018-04-20T16:19:42.000+03:00
diff --git a/src/core.spec.ts b/src/core.spec.ts
@@ -1,18 +1,54 @@
 import { expect } from 'chai';
 import 'mocha';
 import * as inquirerMock from '../test/inquirer-mock';
-import frontvue from './core';
+import frontvue, { loadConfigPlugins } from './core';
+import { configDefaults } from './tasks/task-init-project';
 
 
 describe('Frontvue', () => {
   it('instance', async () => {
     const instance = await frontvue;
+    expect(instance).to.be.an('object')
+      .to.contain.keys('logger', 'name', 'run');
+  }).timeout(20000);
+
+
+  describe('loadConfigPlugins()', () => {
+    let configFetched: boolean = false;
+    let pluginUsed: boolean = false;
+    let configManager: any;
+    let pluginManager: any;
 
-    inquirerMock({
-      fullName: 'John Doe',
-      useDefault: false,
+    beforeEach(() => {
+      configFetched = false;
+      pluginUsed = false;
+
+      // Mocking config manager
+      configManager = {
+        get: (...args: any[]) => {
+          configFetched = true;
+          return Promise.resolve({ plugins: ['some-plugin'] });
+        },
+      };
+      // Mocking plugin manager
+      pluginManager = {
+        use(...args: any[]) {
+          pluginUsed = true;
+          return Promise.resolve(true);
+        },
+      };
     });
 
-    expect(instance).to.be.an('object');
-  }).timeout(20000);
+
+    it('fetches configuration', async () => {
+      await loadConfigPlugins(configManager, pluginManager);
+      expect(configFetched).to.be.true;
+    });
+
+
+    it('calls plugin manager .use() method', async () => {
+      await loadConfigPlugins(configManager, pluginManager);
+      expect(pluginUsed).to.be.true;
+    });
+  });
 });
diff --git a/src/core.ts b/src/core.ts
@@ -5,9 +5,10 @@
  * @since 0.1.0
  */
 
-import ConfigManager from './config-manager';
+import ConfigManager, { IConfigManager } from './config-manager';
+import ConfigManagerProxy from './config-manager/config-manager-proxy';
 import ConfigWizard from './config-wizard';
-import PluginManager from './plugin-manager';
+import PluginManager, { PluginManager as IPluginManager } from './plugin-manager';
 import TaskManager from './task-manager';
 import taskInitProject from './tasks/task-init-project';
 import Logger, { ILogger } from './util/logger';
@@ -23,19 +24,25 @@ const taskManagerConfig = {
   ],
 };
 
-let plugins = [
+let internalPlugins = [
   taskInitProject,
-  'stylus',
 ];
 
 /* test:start */
-// Remove external plugins when testing
-plugins = [
-  taskInitProject,
-];
+// Stop internal plugin loading in TEST environment
+internalPlugins = [];
 /* test:end */
 
 
+/**
+ * Get list of plugins from init config and register them
+ */
+export async function loadConfigPlugins(configManager: IConfigManager, pluginManager: IPluginManager) {
+  const config = ConfigManagerProxy(configManager, 'init');
+  await pluginManager.use(...await config.get('plugins'));
+}
+
+
 /**
  * Main Frontvue constructor
  */
@@ -48,8 +55,16 @@ async function Frontvue() {
   const pluginManager = PluginManager(taskManager, configWizard);
   const { run } = taskManager;
 
-  // Use custom plugin(s)
-  await pluginManager.use(...plugins);
+  // Use internal plugin(s)
+  await pluginManager.use(...internalPlugins);
+
+  // Load external plugins from configuration
+  let loadExternalPlugins = loadConfigPlugins;
+  /* test:start */
+  // Stop external plugin loading in TEST environment by replacing the load function
+  loadExternalPlugins = async () => undefined;
+  /* test:end */
+  await loadExternalPlugins(configManager, pluginManager);
 
   // Return public API
   return Object.freeze({
