test: use headed instead of headful in CLI args (microsoft#1028)

mxschmitt · web-flow · commit 4774b6186a2d · 2021-11-15T19:19:36.000+01:00
diff --git a/tests/async/test_emulation_focus.py b/tests/async/test_emulation_focus.py
@@ -97,7 +97,7 @@ async def test_should_change_document_activeElement(page, server):
 
 
 async def test_should_not_affect_screenshots(page, server, assert_to_be_golden):
-    # Firefox headful produces a different image.
+    # Firefox headed produces a different image.
     page2 = await page.context.new_page()
     await asyncio.gather(
         page.set_viewport_size({"width": 500, "height": 500}),
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -55,7 +55,7 @@ def assetdir() -> Path:
 @pytest.fixture(scope="session")
 def launch_arguments(pytestconfig: Any) -> Dict:
     return {
-        "headless": not pytestconfig.getoption("--headful"),
+        "headless": not pytestconfig.getoption("--headed"),
         "channel": pytestconfig.getoption("--browser-channel"),
     }
 
@@ -181,10 +181,10 @@ def pytest_addoption(parser: Any) -> None:
         help="Browser channel to be used.",
     )
     parser.addoption(
-        "--headful",
+        "--headed",
         action="store_true",
         default=False,
-        help="Run tests in headful mode.",
+        help="Run tests in headed mode.",
     )
 
 

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ def assetdir() -> Path:`
`55`	`55`	`@pytest.fixture(scope="session")`
`56`	`56`	`def launch_arguments(pytestconfig: Any) -> Dict:`
`57`	`57`	`return {`
`58`		`- "headless": not pytestconfig.getoption("--headful"),`
	`58`	`+ "headless": not pytestconfig.getoption("--headed"),`
`59`	`59`	`"channel": pytestconfig.getoption("--browser-channel"),`
`60`	`60`	`}`
`61`	`61`
`@@ -181,10 +181,10 @@ def pytest_addoption(parser: Any) -> None:`
`181`	`181`	`help="Browser channel to be used.",`
`182`	`182`	`)`
`183`	`183`	`parser.addoption(`
`184`		`- "--headful",`
	`184`	`+ "--headed",`
`185`	`185`	`action="store_true",`
`186`	`186`	`default=False,`
`187`		`- help="Run tests in headful mode.",`
	`187`	`+ help="Run tests in headed mode.",`
`188`	`188`	`)`
`189`	`189`
`190`	`190`