chore: remove redundant greenlet for tests (microsoft#1045)

kumaraditya303 · web-flow · commit ed4dcfbb7bf1 · 2021-11-22T11:43:06.000+01:00
diff --git a/playwright/sync_api/_context_manager.py b/playwright/sync_api/_context_manager.py
@@ -25,9 +25,6 @@
 from playwright._impl._transport import PipeTransport
 from playwright.sync_api._generated import Playwright as SyncPlaywright
 
-# Used for sync API tests
-dispatcher_fiber: Any = None
-
 
 class PlaywrightContextManager:
     def __init__(self) -> None:
@@ -54,7 +51,6 @@ def greenlet_main() -> None:
                 loop.run_until_complete(loop.shutdown_asyncgens())
                 loop.close()
 
-        global dispatcher_fiber
         dispatcher_fiber = greenlet(greenlet_main)
         self._connection = Connection(
             dispatcher_fiber,
diff --git a/tests/server.py b/tests/server.py
@@ -25,14 +25,12 @@
 from urllib.parse import urlparse
 
 from autobahn.twisted.websocket import WebSocketServerFactory, WebSocketServerProtocol
-from greenlet import greenlet
 from OpenSSL import crypto
 from twisted.internet import reactor, ssl
 from twisted.internet.protocol import ClientFactory
 from twisted.web import http
 
 from playwright._impl._path_utils import get_file_dirname
-from playwright.sync_api._context_manager import dispatcher_fiber
 
 _dirname = get_file_dirname()
 
@@ -164,17 +162,13 @@ def expect_request(
     ) -> Generator[ExpectResponse[http.Request], None, None]:
         future = asyncio.create_task(self.wait_for_request(path))
 
-        g_self = greenlet.getcurrent()
         cb_wrapper: ExpectResponse[http.Request] = ExpectResponse()
 
         def done_cb(task: asyncio.Task) -> None:
             cb_wrapper._value = future.result()
-            g_self.switch()
 
         future.add_done_callback(done_cb)
         yield cb_wrapper
-        while not future.done():
-            dispatcher_fiber.switch()
 
     def set_auth(self, path: str, username: str, password: str) -> None:
         self.auth[path] = (username, password)
