Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streams] Save a message for each streamer registered #3824

Open
2 of 3 tasks
madebylydia opened this issue May 6, 2020 · 5 comments · May be fixed by #4668
Open
2 of 3 tasks

[Streams] Save a message for each streamer registered #3824

madebylydia opened this issue May 6, 2020 · 5 comments · May be fixed by #4668
Labels
Category: Cogs - Streams This is related to the Streams cog. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Feature New feature or request.

Comments

@madebylydia
Copy link
Contributor

madebylydia commented May 6, 2020

Feature request

Select the type of feature you are requesting:

  • Cog
  • Command
  • API functionality

Describe your requested feature

This is an improvement idea for the Streams cog:

Save a message for each streamer we record, but keep the mention/no mention system for the "default" message:

  • Make a command [p]streamset message streamer <Streamer name> <Message>. It will save the message to the streamer.
    • Streamer must be already registered.
    • Command can be run by moderator.
    • Can be only used in server.
  • If this command was not executed after the streamer was created, use the default guild option (Mention or not).
@madebylydia madebylydia added the Type: Feature New feature or request. label May 6, 2020
@github-actions github-actions bot added the Status: Needs Triage This has not been labeled or discussed for handling yet. label May 6, 2020
@Tobotimus
Copy link
Member

I like this idea, and it's actually something we use at the R6 ANZ Discord, except we just hard-code the channel we want to have a custom mention for :D In R6 ANZ we make the official Twitch channel for the organization mention @here whenever it goes live. Definitely a valid use-case, and I don't mind your design either.

@Tobotimus Tobotimus added Category: Cogs - Streams This is related to the Streams cog. Status: PRs Welcome No one is currently assigned to this issue, but we'd be grateful if anyone made a PR. and removed Status: Needs Triage This has not been labeled or discussed for handling yet. labels May 7, 2020
@KianBral
Copy link
Contributor

KianBral commented Dec 2, 2020

How would I be able to check if the streamer is already registered?

Also, is the @commands.guild_only() decorator okay to use for this command/function?

@ltzmax
Copy link
Contributor

ltzmax commented Dec 2, 2020

How would I be able to check if the streamer is already registered?

You should see those you've added in [p]streamalert list. I assume that's what you mean.

@Jackenmen Jackenmen added Status: In Progress There's a PR open to deal with this, or an org member is working on this internally and removed Status: PRs Welcome No one is currently assigned to this issue, but we'd be grateful if anyone made a PR. labels Apr 21, 2021
@SharkyTheKing
Copy link
Contributor

Any possible updates on this? Was looking into if this was something that was already being talked about/worked on and saw this issue, so figured to leave a comment.

@Jackenmen
Copy link
Member

It seems that there's an open PR for this. The best way to move this forward would be for an interested contributor to make a code review of it and explain in more detail some of the issues with its style such as:

  • usage of __setattr__, __delattr__, hasattr instead of regular attribute access with default values
    • somewhat related, there's no point in having streamer_info when it can be passed directly to the Stream class
  • explanation of why _("...".format(...)) should be _("...").format(...)
  • explanation of why using named fields in .format() calls is preferred to positional arguments

It might also be worth first asking the author whether they're still even interested in pursuing this PR as if not, it could simply be closed and another one made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Streams This is related to the Streams cog. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Feature New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy