You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bug description
When uploading a new file into DefectDojo (Engagement, Test, Finding), the title is unique due to the model declaration: title = models.CharField(max_length=100, unique=True)
Thus, it is not only unique for that Engagement, Test or Finding but for the whole DefectDojo instance.
Steps to reproduce
Steps to reproduce the behavior:
Go to Manage Files in Engagement, Test or Finding
Upload a first file called "Test"
Go to a different Engagement, Test or Finding
Upload a new file called "Test"
"File with this name already exists" pops
Expected behavior
Even if the Title could be a way of recognizing the file, as DD is intended to store a lot of Findings (then lot of engagements, tests, etc.), it's quite common that the chosen title will often or always match one already existing. For example, naming XSS, or Screenshot 1, etc. Thus, it become more and more complicated with time to find a title that has not been used yet and feature seems impossible to use.
Title should allow non unique values and maybe should allow 1000 chars and not just 100. Or, maybe should be split into 2 fields adding some kind of description in the FileUpload class?
The text was updated successfully, but these errors were encountered:
I also notice there's a ManyToMany relationship between FileUpload and Test or Finding or Engagement. Not sure if that is needed, I think it could be a OneToMany.
@Maffooch@mtesauro Any thoughts on this and the issue reported by @X0x1RG9f ? If a FileUpload record has a unique id the title might not need to be unique at all? Or could be made unique by Defect Dojo by adding some random suffix similar to what is happening when a Finding and its files are copied?
Bug description
When uploading a new file into DefectDojo (Engagement, Test, Finding), the title is unique due to the model declaration:
title = models.CharField(max_length=100, unique=True)
Thus, it is not only unique for that Engagement, Test or Finding but for the whole DefectDojo instance.
Steps to reproduce
Steps to reproduce the behavior:
Expected behavior
Even if the Title could be a way of recognizing the file, as DD is intended to store a lot of Findings (then lot of engagements, tests, etc.), it's quite common that the chosen title will often or always match one already existing. For example, naming XSS, or Screenshot 1, etc. Thus, it become more and more complicated with time to find a title that has not been used yet and feature seems impossible to use.
Title should allow non unique values and maybe should allow 1000 chars and not just 100. Or, maybe should be split into 2 fields adding some kind of description in the FileUpload class?
The text was updated successfully, but these errors were encountered: