Skip to content

Commit 9078eba

Browse files
committed
Fixing API mismatch in .NET ChromeOptions and rereleasing as 2.50.1
1 parent e212e3a commit 9078eba

File tree

6 files changed

+29
-9
lines changed

6 files changed

+29
-9
lines changed

dotnet/CHANGELOG

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
v2.50.1
2+
=======
3+
* Changed ChromeOptions to have correct EnableMobileEmulation API.
4+
15
v2.50.0
26
=======
37
* Updated embedded Firefox driver with new click algorithm

dotnet/src/core/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@
2121
// Minor Version
2222
// Build Number
2323
// Revision
24-
[assembly: AssemblyVersion("2.50.0.0")]
25-
[assembly: AssemblyFileVersion("2.50.0.0")]
24+
[assembly: AssemblyVersion("2.50.1.0")]
25+
[assembly: AssemblyFileVersion("2.50.1.0")]

dotnet/src/support/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,5 @@
5050
// Minor Version
5151
// Build Number
5252
// Revision
53-
[assembly: AssemblyVersion("2.50.0.0")]
54-
[assembly: AssemblyFileVersion("2.50.0.0")]
53+
[assembly: AssemblyVersion("2.50.1.0")]
54+
[assembly: AssemblyFileVersion("2.50.1.0")]

dotnet/src/webdriver/Chrome/ChromeOptions.cs

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ public void EnableMobileEmulation(string deviceName)
412412
/// <remarks>Specifying an invalid device name will not throw an exeption, but
413413
/// will generate an error in Chrome when the driver starts. To unset mobile
414414
/// emulation, call this method with <see langword="null"/> as the argument.</remarks>
415-
public void EnableMobileDeviceEmulation(ChromeMobileEmulationDeviceSettings deviceSettings)
415+
public void EnableMobileEmulation(ChromeMobileEmulationDeviceSettings deviceSettings)
416416
{
417417
this.mobileEmulationDeviceName = null;
418418
if (deviceSettings != null && string.IsNullOrEmpty(deviceSettings.UserAgent))
@@ -423,6 +423,22 @@ public void EnableMobileDeviceEmulation(ChromeMobileEmulationDeviceSettings devi
423423
this.mobileEmulationDeviceSettings = deviceSettings;
424424
}
425425

426+
/// <summary>
427+
/// Allows the Chrome browser to emulate a mobile device.
428+
/// </summary>
429+
/// <param name="deviceSettings">The <see cref="ChromeMobileEmulationDeviceSettings"/>
430+
/// object containing the settings of the device to emulate.</param>
431+
/// <exception cref="ArgumentException">Thrown if the device settings option does
432+
/// not have a user agent string set.</exception>
433+
/// <remarks>Specifying an invalid device name will not throw an exeption, but
434+
/// will generate an error in Chrome when the driver starts. To unset mobile
435+
/// emulation, call this method with <see langword="null"/> as the argument.</remarks>
436+
[Obsolete("Use the EnableMobileEmulation method instead. This method was released in error, and will be removed in a future release.")]
437+
public void EnableMobileDeviceEmulation(ChromeMobileEmulationDeviceSettings deviceSettings)
438+
{
439+
this.EnableMobileEmulation(deviceSettings);
440+
}
441+
426442
/// <summary>
427443
/// Adds a type of window that will be listed in the list of window handles
428444
/// returned by the Chrome driver.

dotnet/src/webdriver/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,5 @@
4949
// Minor Version
5050
// Build Number
5151
// Revision
52-
[assembly: AssemblyVersion("2.50.0.0")]
53-
[assembly: AssemblyFileVersion("2.50.0.0")]
52+
[assembly: AssemblyVersion("2.50.1.0")]
53+
[assembly: AssemblyFileVersion("2.50.1.0")]

dotnet/src/webdriverbackedselenium/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,5 @@
5050
// Minor Version
5151
// Build Number
5252
// Revision
53-
[assembly: AssemblyVersion("2.50.0.0")]
54-
[assembly: AssemblyFileVersion("2.50.0.0")]
53+
[assembly: AssemblyVersion("2.50.1.0")]
54+
[assembly: AssemblyFileVersion("2.50.1.0")]

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy