squash this commit: changes as recommended by Codacy

Zananok · Zananok · commit e783ff6c67d0 · 2025-04-18T11:52:30.000+02:00
diff --git a/src/KafkaFlow.Abstractions/Producers/IDeliveryReportFlow.cs b/src/KafkaFlow.Abstractions/Producers/IDeliveryReportFlow.cs
@@ -5,7 +5,7 @@ namespace KafkaFlow;
 /// </summary>
 /// <typeparam name="TKey"></typeparam>
 /// <typeparam name="TValue"></typeparam>
-public interface IDeliveryReportFlow<TKey, TValue>
+public interface IDeliveryReportFlow<out TKey, TValue>
 {
     string Topic { get; }
 
diff --git a/src/KafkaFlow.Abstractions/Producers/IDeliveryResultFlow.cs b/src/KafkaFlow.Abstractions/Producers/IDeliveryResultFlow.cs
@@ -7,7 +7,7 @@ namespace KafkaFlow;
 /// </summary>
 /// <typeparam name="TKey"></typeparam>
 /// <typeparam name="TValue"></typeparam>
-public interface IDeliveryResultFlow<TKey, TValue>
+public interface IDeliveryResultFlow<out TKey, TValue>
 {
     string Topic { get; }
 
diff --git a/src/KafkaFlow/Producers/DeliveryReportExtension.cs b/src/KafkaFlow/Producers/DeliveryReportExtension.cs
@@ -4,28 +4,10 @@
 namespace KafkaFlow;
 
 /// <summary>
-/// Converts between KafkaFlow and Confluent.Kafka delivery reports.
+/// No needed
 /// </summary>
 public static class DeliveryReportExtension
 {
-    /// <summary>
-    /// Converts a Confluent.Kafka delivery report to a KafkaFlow delivery report.
-    /// </summary>
-    /// <param name="report"></param>
-    /// <typeparam name="TKey"></typeparam>
-    /// <typeparam name="TValue"></typeparam>
-    /// <returns></returns>
-    public static DeliveryReport<TKey, TValue> ToDeliveryReport<TKey, TValue>(this IDeliveryReportFlow<TKey, TValue> report)
-    {
-        return new DeliveryReport<TKey, TValue>
-        {
-            Topic = report.Topic,
-            Partition = report.Partition,
-            Offset = report.Offset,
-            Error = report.Error.ToError(),
-        };
-    }
-
     /// <summary>
     /// Converts a Confluent.Kafka delivery report to a KafkaFlow delivery report.
     /// </summary>
diff --git a/src/KafkaFlow/Producers/DeliveryResultExtension.cs b/src/KafkaFlow/Producers/DeliveryResultExtension.cs
@@ -4,40 +4,10 @@
 namespace KafkaFlow.Producers;
 
 /// <summary>
-/// Converts between KafkaFlow and Confluent.Kafka delivery results.
+/// No needed
 /// </summary>
 public static class DeliveryResultExtension
 {
-    /// <summary>
-    /// Converts a Confluent.Kafka delivery result to a KafkaFlow delivery result.
-    /// </summary>
-    /// <param name="deliveryResult"></param>
-    /// <typeparam name="TKey"></typeparam>
-    /// <typeparam name="TValue"></typeparam>
-    /// <returns></returns>
-    /// <exception cref="ArgumentNullException"></exception>
-    public static DeliveryResult<TKey, TValue> ToDeliveryResult<TKey, TValue>(
-        this IDeliveryResultFlow<TKey, TValue> deliveryResult)
-    {
-        if (deliveryResult is null)
-        {
-            throw new ArgumentNullException(nameof(deliveryResult));
-        }
-
-        return new DeliveryResult<TKey, TValue>
-        {
-            Topic = deliveryResult.Topic,
-            Partition = deliveryResult.Partition,
-            Offset = deliveryResult.Offset,
-            Status = (PersistenceStatus)deliveryResult.Status,
-            Message = (Message<TKey, TValue>)deliveryResult.Message,
-            Key = deliveryResult.Key,
-            Value = deliveryResult.Value,
-            Timestamp = new Timestamp(deliveryResult.Timestamp),
-            Headers = (Headers)deliveryResult.Headers,
-        };
-    }
-
     /// <summary>
     /// Converts a KafkaFlow delivery result to a Confluent.Kafka delivery result.
     /// </summary>
diff --git a/src/KafkaFlow/Producers/IDeliveryReportFlowExtension.cs b/src/KafkaFlow/Producers/IDeliveryReportFlowExtension.cs
@@ -0,0 +1,28 @@
+using Confluent.Kafka;
+using KafkaFlow.Producers;
+
+namespace KafkaFlow;
+
+/// <summary>
+/// No needed
+/// </summary>
+public static class IDeliveryReportFlowExtension
+{
+    /// <summary>
+    /// Converts a Confluent.Kafka delivery report to a KafkaFlow delivery report.
+    /// </summary>
+    /// <param name="report"></param>
+    /// <typeparam name="TKey"></typeparam>
+    /// <typeparam name="TValue"></typeparam>
+    /// <returns></returns>
+    public static DeliveryReport<TKey, TValue> ToDeliveryReport<TKey, TValue>(this IDeliveryReportFlow<TKey, TValue> report)
+    {
+        return new DeliveryReport<TKey, TValue>
+        {
+            Topic = report.Topic,
+            Partition = report.Partition,
+            Offset = report.Offset,
+            Error = report.Error.ToError(),
+        };
+    }
+}
diff --git a/src/KafkaFlow/Producers/IDeliveryResultFlowExtension.cs b/src/KafkaFlow/Producers/IDeliveryResultFlowExtension.cs
@@ -0,0 +1,40 @@
+using System;
+using Confluent.Kafka;
+
+namespace KafkaFlow.Producers;
+
+/// <summary>
+/// No needed
+/// </summary>
+public static class IDeliveryResultFlowExtension
+{
+    /// <summary>
+    /// Converts a Confluent.Kafka delivery result to a KafkaFlow delivery result.
+    /// </summary>
+    /// <param name="deliveryResult"></param>
+    /// <typeparam name="TKey"></typeparam>
+    /// <typeparam name="TValue"></typeparam>
+    /// <returns></returns>
+    /// <exception cref="ArgumentNullException"></exception>
+    public static DeliveryResult<TKey, TValue> ToDeliveryResult<TKey, TValue>(
+        this IDeliveryResultFlow<TKey, TValue> deliveryResult)
+    {
+        if (deliveryResult is null)
+        {
+            throw new ArgumentNullException(nameof(deliveryResult));
+        }
+
+        return new DeliveryResult<TKey, TValue>
+        {
+            Topic = deliveryResult.Topic,
+            Partition = deliveryResult.Partition,
+            Offset = deliveryResult.Offset,
+            Status = (PersistenceStatus)deliveryResult.Status,
+            Message = (Message<TKey, TValue>)deliveryResult.Message,
+            Key = deliveryResult.Key,
+            Value = deliveryResult.Value,
+            Timestamp = new Timestamp(deliveryResult.Timestamp),
+            Headers = (Headers)deliveryResult.Headers,
+        };
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ namespace KafkaFlow;`
`5`	`5`	`/// </summary>`
`6`	`6`	`/// <typeparam name="TKey"></typeparam>`
`7`	`7`	`/// <typeparam name="TValue"></typeparam>`
`8`		`-public interface IDeliveryReportFlow<TKey, TValue>`
	`8`	`+public interface IDeliveryReportFlow<out TKey, TValue>`
`9`	`9`	`{`
`10`	`10`	`string Topic { get; }`
`11`	`11`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ namespace KafkaFlow;`
`7`	`7`	`/// </summary>`
`8`	`8`	`/// <typeparam name="TKey"></typeparam>`
`9`	`9`	`/// <typeparam name="TValue"></typeparam>`
`10`		`-public interface IDeliveryResultFlow<TKey, TValue>`
	`10`	`+public interface IDeliveryResultFlow<out TKey, TValue>`
`11`	`11`	`{`
`12`	`12`	`string Topic { get; }`
`13`	`13`