Integrated payment #6754
Draft
Integrated payment #6754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fixed a warning about undefined array element.
Any person having a clear purpose on this page has already bought an account.
This fixes phpstan warnings.
|
Hello and thanks for the draft. Do you believe this could be contained in a FreshRSS extension, possibly after adding more hooks? |
| } | ||
|
|
||
| public function issueTicketAction(): void { | ||
| require '../../vendor/autoload.php'; |
There was a problem hiding this comment.
suggestion : Hi, Shouldn't the call for autoload be made in such a way as to benefit the whole project
Comment on lines
+71
to
+77
| 'customer' => array( | ||
| 'buy' => array( | ||
| '_' => 'Buy an account', | ||
| 'ask' => 'Buy an account?', | ||
| 'title' => 'Buy an account', | ||
| ), | ||
| ), |
There was a problem hiding this comment.
please, use [ ] for arrays
Let's see later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is me sharing how I implemented paid automated signup.
Seems that ideally this would become a system-wide extension rather than core part, but I am not sure if it will work.
I would highly appreciate criticism around security. First time writing such code, so am worried.
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist:
Additional information can be found in the documentation.