-
-
Notifications
You must be signed in to change notification settings - Fork 950
Improved: Reorg slider buttons #6755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: edge
Are you sure you want to change the base?
Conversation
please give feedback before I will do the left open tasks |
I do not really mind. One the one hand, this looks fine; on the other hand, I am used to have the delete whatever at the bottom of settings, also in other systems than FreshRSS |
The delete botton is in this case (feed config) not at the bottom of the settings. It is below the first form box. In other cases the delete button is at the bottom of all settings (i.e. category config) |
I'm not a fan of any of these changes I'm afraid. :-/ Moving delete to the top especially. It's this big in your face red button (because it's dangerous; that shouldn't change) that you almost never want to click on, except in rare cases when you're actually looking for it. But also styling links like buttons is just not something I care much for in general. It depends on the specifics of course, but what's the reason for styling these links as buttons, making it look like they perform an action?
If that's considered problematic I'd take that as an argument to move it down to maintenance. |
PS I personally want to click on it quite frequently because I add feeds from people posting issues here, but I don't believe such an atypical use case should guide design. |
Ref. #3380 (number 2)
Changes proposed in this pull request:
remove
button upperfilter
link/button: frommouse cursor
icon to theeye
iconBefore:

After:

How to test the feature manually:
Pull request checklist:
Todos left:
.btn-attention
)