Skip to content

Improved: Reorg slider buttons #6755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: edge
Choose a base branch
from

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Aug 31, 2024

Ref. #3380 (number 2)

Changes proposed in this pull request:

  • added a trash icon
  • moved the remove button upper
  • the filter and statistic link looks now like a button
  • this 3 buttons are now in the same row
  • changed the icon for the filter link/button: from mouse cursor icon to the eye icon

Before:
grafik

After:
grafik

How to test the feature manually:

  1. open the feed config
  2. check the filter button
  3. check the statistic button
  4. check the remove/delete button

Pull request checklist:

  • clear commit messages
  • code manually tested

Todos left:

  • style the trash icon button in the other themes too (.btn-attention)
  • config category
  • config user query
  • config label management

@math-GH math-GH added UI 🎨 User Interfaces UX User experience labels Aug 31, 2024
@math-GH math-GH added this to the 1.25.0 milestone Aug 31, 2024
@math-GH
Copy link
Contributor Author

math-GH commented Aug 31, 2024

please give feedback before I will do the left open tasks

@Alkarex
Copy link
Member

Alkarex commented Sep 7, 2024

I do not really mind. One the one hand, this looks fine; on the other hand, I am used to have the delete whatever at the bottom of settings, also in other systems than FreshRSS

@math-GH
Copy link
Contributor Author

math-GH commented Sep 7, 2024

I do not really mind. One the one hand, this looks fine; on the other hand, I am used to have the delete whatever at the bottom of settings, also in other systems than FreshRSS

The delete botton is in this case (feed config) not at the bottom of the settings. It is below the first form box. In other cases the delete button is at the bottom of all settings (i.e. category config)

@Frenzie
Copy link
Member

Frenzie commented Sep 8, 2024

I'm not a fan of any of these changes I'm afraid. :-/ Moving delete to the top especially. It's this big in your face red button (because it's dangerous; that shouldn't change) that you almost never want to click on, except in rare cases when you're actually looking for it. But also styling links like buttons is just not something I care much for in general. It depends on the specifics of course, but what's the reason for styling these links as buttons, making it look like they perform an action?

The delete botton is in this case (feed config) not at the bottom of the settings. It is below the first form box. In other cases the delete button is at the bottom of all settings (i.e. category config)

If that's considered problematic I'd take that as an argument to move it down to maintenance.

@Frenzie
Copy link
Member

Frenzie commented Sep 8, 2024

except in rare cases when you're actually looking for it.

PS I personally want to click on it quite frequently because I add feeds from people posting issues here, but I don't believe such an atypical use case should guide design.

@Alkarex Alkarex modified the milestones: 1.25.0, 1.26.0 Nov 30, 2024
@Alkarex Alkarex modified the milestones: 1.26.0, 1.27.0 Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy