-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swipe scroll on mac and chrome triggers forward or back scroll #1397
Comments
Not observed at all in JBrowse2 AFAICT |
Usually this is when something on the page hits a horizontal scroll limit (at least with trello). |
Works with all versions 1.12 to 08c9e7e (June 12th) . . I'll roll it forward and see |
This fails: 8a041eb |
I see. That's unfortunate. We'll have to roll back that change I guess. There is a config flag you can add to jbrowse.conf "alwaysStopScrollBubble=true" that may help this. Can you try that |
@cmdcolin that definitely fixes it. Could we just change the default to true? It might be the simpler fix. |
Yes that should be fine actually. That code change was only designed to affect vertical scrolling but is somehow affecting left right scrolling with the mac touchpad...works fine with my touchpad weirdly enough. We can either try to fix that just turn that config item to true by default |
@cmdcolin I'm not sure the behavior its trying to fix, but setting it to true by default works for me. Do you want to make that fix or should I? |
This change should fix it instead 4b44f87 I just pushed it it to dev in case you want to test |
Thanks for catching this |
@cmdcolin Tested and works. Thanks for the fix! |
When scrolling to the left or the right on the mac in Chrome with JBrowse 1.16.5 (and similarly Apollo) it triggers a back or forward scroll. Per topic: https://groups.google.com/a/lbl.gov/forum/#!topic/apollo/Dk2AUoyQJY4
More details:
The text was updated successfully, but these errors were encountered: