chore: drop Python 3.7 (microsoft#1980)

mxschmitt · web-flow · commit 062059604022 · 2023-06-16T21:50:23.000+02:00
diff --git a/.github/ISSUE_TEMPLATE/bug.md b/.github/ISSUE_TEMPLATE/bug.md
@@ -10,7 +10,7 @@ assignees: ''
 **Context:**
 - Playwright Version: [what Playwright version do you use?]
 - Operating System: [e.g. Windows, Linux or Mac]
-- Python version: [e.g. 3.7, 3.9]
+- Python version: [e.g. 3.8, 3.9]
 - Browser: [e.g. All, Chromium, Firefox, WebKit]
 - Extra: [any specific details about your environment]
 
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -43,34 +43,13 @@ jobs:
   build:
     name: Build
     timeout-minutes: 45
-    env:
-      DEBUG: pw:*
-      DEBUG_FILE: pw-log.txt
     strategy:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        python-version: [3.7, 3.8]
+        python-version: [3.8, 3.9]
         browser: [chromium, firefox, webkit]
         include:
-        - os: ubuntu-latest
-          python-version: 3.9
-          browser: chromium
-        - os: windows-latest
-          python-version: 3.9
-          browser: chromium
-        - os: macos-latest
-          python-version: 3.9
-          browser: chromium
-        - os: macos-11.0
-          python-version: 3.9
-          browser: chromium
-        - os: macos-11.0
-          python-version: 3.9
-          browser: firefox
-        - os: macos-11.0
-          python-version: 3.9
-          browser: webkit
         - os: ubuntu-latest
           python-version: '3.10'
           browser: chromium
@@ -129,18 +108,10 @@ jobs:
     - name: Test Async API
       if: matrix.os == 'ubuntu-latest'
       run: xvfb-run pytest tests/async --browser=${{ matrix.browser }} --timeout 90
-    - uses: actions/upload-artifact@v3
-      if: failure()
-      with:
-        name: ${{ matrix.browser }}-${{ matrix.os }}-${{ matrix.python-version }}
-        path: pw-log.txt
 
   test-stable:
     name: Stable
     timeout-minutes: 45
-    env:
-      DEBUG: pw:*
-      DEBUG_FILE: pw-log.txt
     strategy:
       fail-fast: false
       matrix:
@@ -179,11 +150,6 @@ jobs:
     - name: Test Async API
       if: matrix.os == 'ubuntu-latest'
       run: xvfb-run pytest tests/async --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
-    - uses: actions/upload-artifact@v3
-      if: failure()
-      with:
-        name: ${{ matrix.browser-channel }}-${{ matrix.os }}
-        path: pw-log.txt
 
   build-conda:
     name: Conda Build
diff --git a/playwright/_impl/_driver.py b/playwright/_impl/_driver.py
@@ -12,7 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import asyncio
 import inspect
 import os
 import sys
@@ -30,22 +29,6 @@ def compute_driver_executable() -> Path:
     return package_path / "driver" / "playwright.sh"
 
 
-if sys.version_info.major == 3 and sys.version_info.minor == 7:
-    if sys.platform == "win32":
-        # Use ProactorEventLoop in 3.7, which is default in 3.8
-        asyncio.set_event_loop_policy(asyncio.WindowsProactorEventLoopPolicy())
-    else:
-        # Prevent Python 3.7 from throwing on Linux:
-        # RuntimeError: Cannot add child handler, the child watcher does not have a loop attached
-        asyncio.get_event_loop()
-        try:
-            asyncio.get_child_watcher()
-        except Exception:
-            # uvloop does not support child watcher
-            # see https://github.com/microsoft/playwright-python/issues/582
-            pass
-
-
 def get_driver_env() -> dict:
     env = os.environ.copy()
     env["PW_LANG_NAME"] = "python"
diff --git a/playwright/sync_api/_context_manager.py b/playwright/sync_api/_context_manager.py
@@ -13,7 +13,6 @@
 # limitations under the License.
 
 import asyncio
-import sys
 from typing import TYPE_CHECKING, Any, Optional, cast
 
 from greenlet import greenlet
@@ -50,20 +49,6 @@ def __enter__(self) -> SyncPlaywright:
 Please use the Async API instead."""
             )
 
-        # In Python 3.7, asyncio.Process.wait() hangs because it does not use ThreadedChildWatcher
-        # which is used in Python 3.8+. This is unix specific and also takes care about
-        # cleaning up zombie processes. See https://bugs.python.org/issue35621
-        if (
-            sys.version_info[0] == 3
-            and sys.version_info[1] == 7
-            and sys.platform != "win32"
-            and isinstance(asyncio.get_child_watcher(), asyncio.SafeChildWatcher)
-        ):
-            from ._py37ThreadedChildWatcher import ThreadedChildWatcher  # type: ignore
-
-            self._watcher = ThreadedChildWatcher()
-            asyncio.set_child_watcher(self._watcher)  # type: ignore
-
         # Create a new fiber for the protocol dispatcher. It will be pumping events
         # until the end of times. We will pass control to that fiber every time we
         # block while waiting for a response.
diff --git a/playwright/sync_api/_py37ThreadedChildWatcher.py b/playwright/sync_api/_py37ThreadedChildWatcher.py
diff --git a/pyproject.toml b/pyproject.toml
@@ -15,7 +15,7 @@ asyncio_mode = "auto"
 
 [tool.mypy]
 ignore_missing_imports = true
-python_version = "3.7"
+python_version = "3.8"
 warn_unused_ignores = false
 warn_redundant_casts = true
 warn_unused_configs = true
@@ -32,7 +32,7 @@ profile = "black"
 [tool.pyright]
 include = ["playwright", "tests/sync"]
 ignore = ["tests/async/", "scripts/", "examples/"]
-pythonVersion = "3.7"
+pythonVersion = "3.8"
 reportMissingImports = false
 reportTypedDictNotRequiredAccess = false
 reportCallInDefaultInitializer = true
diff --git a/setup.py b/setup.py
@@ -221,15 +221,14 @@ def _download_and_extract_local_driver(
         "Topic :: Internet :: WWW/HTTP :: Browsers",
         "Intended Audience :: Developers",
         "Programming Language :: Python :: 3",
-        "Programming Language :: Python :: 3.7",
         "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "License :: OSI Approved :: Apache Software License",
         "Operating System :: OS Independent",
     ],
-    python_requires=">=3.7",
+    python_requires=">=3.8",
     cmdclass={"bdist_wheel": PlaywrightBDistWheelCommand},
     use_scm_version={
         "version_scheme": "post-release",
