Skip to content

fix: typed declaration works correctly with http trigger #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

garethgeorge
Copy link
Contributor

@garethgeorge garethgeorge commented Jun 23, 2023

  • Makes typed functions compatible with HTTP triggers by updating Invoker to select a TypedFunctionExecutor if the signature is http and TypedFunction interface. This allows typed functions to be used on Google Cloud in the place of http functions without changing the trigger type.
  • Adds conformance test coverage.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jun 23, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@garethgeorge garethgeorge marked this pull request as draft June 23, 2023 20:32
@garethgeorge garethgeorge changed the title chore: configure typed function conformance test fix: typed declaration works correctly with http trigger Jun 23, 2023
@garethgeorge garethgeorge marked this pull request as ready for review June 23, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy