fix: server times out when specified by CLOUD_RUN_TIMEOUT_SECONDS #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
janell-chen
commented
Jun 25, 2024
- feature: adds timeout limit to jetty server specified by CLOUD_RUN_TIMEOUT_SECONDS
- adds test coverage
jrmfg
reviewed
Jun 26, 2024
invoker/core/src/main/java/com/google/cloud/functions/invoker/runner/Invoker.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
87c843c to
21bb6fc
Compare
jrmfg
reviewed
Jul 3, 2024
invoker/core/src/main/java/com/google/cloud/functions/invoker/http/TimeoutFilter.java
Outdated
Show resolved
Hide resolved
jrmfg
reviewed
Jul 3, 2024
invoker/core/src/main/java/com/google/cloud/functions/invoker/http/TimeoutFilter.java
Outdated
Show resolved
Hide resolved
invoker/core/src/test/java/com/google/cloud/functions/invoker/IntegrationTest.java
Show resolved
Hide resolved
invoker/core/src/main/java/com/google/cloud/functions/invoker/http/TimeoutFilter.java
Outdated
Show resolved
Hide resolved
jrmfg
approved these changes
Jul 8, 2024
invoker/core/src/main/java/com/google/cloud/functions/invoker/http/TimeoutFilter.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.