Skip to content

Split up syntax.jl tests in Base so that JuliaSyntax can test the non-controversial parts. #533

New issue
New issue
Open
Open
Split up syntax.jl tests in Base so that JuliaSyntax can test the non-controversial parts.#533
@KristofferC

Description

@KristofferC
KristofferC
opened on Feb 4, 2025

Right now, the syntax.jl tests are skipped (

JuliaSyntax.jl/test/parse_packages.jl

Lines 41 to 46 in 2e965a1

# syntax.jl has some intentionally weird syntax which we parse
# differently than the flisp parser, and some cases which we've
# decided are syntax errors.
if endswith(f, "syntax.jl")
return nothing
end
). However, this causes us to sometimes regress, see e.g. https://github.com/JuliaLang/julia/pull/57188/files#diff-266674e240feff7742a800c1c360befe28cd7a20f49dada34fef94a122acd90b where the test got changed and then caused regressions JuliaLang/julia#57223.

It would probably be a good idea to split up syntax.jl into a "controversial" part which is not tested by JuliaSyntax and a standard part which does get tested. Ideally, as time moves on the controversial part is shrunk.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy