Skip to content

Onboarding Screen #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 26, 2022
Merged

Onboarding Screen #906

merged 5 commits into from
Jan 26, 2022

Conversation

the0neyouseek
Copy link
Member

@the0neyouseek the0neyouseek commented Jan 22, 2022 •
edited
Loading

This PR is related to this issue: #676

What's new

  • ✨ Add an onboarding screen (only appear on first launch)
  • 🇫🇷 French translations for the new onboarding screen
  • 🛠 Reorganize AppDelegate a bit
  • 🛠 Move View Controllers into folders

Tests

I've tested the onboarding screen on both small and large screen, HiDPI and normal res, light and dark mode.

If you want to test the PR you can save your preferences located here:

~/Library/Preferences/me.guillaumeb.MonitorControl.plist

and run this command to reset your current preferences (where the app check to know if it was started once)

$ defaults delete me.guillaumeb.MonitorControl

before the launching the project in XCode.

What's left to do

All current translations beside French & English (for the new onboarding) are missing for now.
If you want to help with translations, please read the opening post of this discussion: #637

  • Translations :
    • Spanish
    • German
    • Hungarian
    • Italian
    • Korean
    • Dutch
    • Portuguese (Brazil)
    • Turkish
    • Chinese, Simplified
    • Chinese, Traditional (Taïwan)
  • I also forgot to translate the keyboard screenshot part (I'll get to it asap)

@the0neyouseek
feat: Onboarding Screen
de80229 
- Add an onboarding screen (only appear on first launch)
- 🇫🇷 French translations for the new onboarding screen
- Reorganize AppDelegate a bit
- Move View Controllers into folders
@the0neyouseek the0neyouseek added Type: Enhancement in progress Issue currently being worked on labels Jan 22, 2022
waydabber
waydabber previously approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@waydabber waydabber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Good job!

@the0neyouseek
Copy link
Member Author

I think i'm done with this PR, feel free to add commits if you want to maybe add some translations @waydabber @JoniVR

@waydabber
Copy link
Member

waydabber commented Jan 23, 2022 •
edited
Loading

He @the0neyouseek - I have an issue - something seems to be off.

Screen Shot 2022-01-23 at 16 58 46

Steps to reproduce:

  • delete app defaults defaults delete me.guillaumeb.MonitorControl
  • pull the latest code from feat/onboarding
  • build&run

Also, besides the unexpected nil, the onboarding screen does not pop up now (it did pop up when I did the last approve as I tested it - so something must have changed since then) and a complaint about permissions do pop up (when security permissions are not granted to the app) - I thought this should not present itself before the onboarding so it is not the first impression.

@the0neyouseek
Copy link
Member Author

the0neyouseek commented Jan 23, 2022 •
edited
Loading

That's weird. Maybe I messed something up, I'll look into it.
Edit: Yup, it's me, I messed up the merge…

@the0neyouseek the0neyouseek added done Work on this issue is complete. Will be available on next release in progress Issue currently being worked on and removed in progress Issue currently being worked on labels Jan 23, 2022
waydabber
waydabber approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@waydabber waydabber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly now! :)

@waydabber
Copy link
Member

Hey @the0neyouseek - is this PR now done or you still working on it? Shouldn't it be merged? :)

@the0neyouseek
Copy link
Member Author

Done for me :) You can merge it

@waydabber waydabber merged commit e60ffc9 into main Jan 26, 2022
@waydabber waydabber deleted the feat/onboarding branch January 26, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waydabber waydabber waydabber approved these changes

@JoniVR JoniVR Awaiting requested review from JoniVR

Assignees
No one assigned
Labels
done Work on this issue is complete. Will be available on next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the0neyouseek @waydabber
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy