Test: provide a function to report working directory and library paths #7734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Brief overview of PR changes/additions Adds `applicationPaths()` function to Lua API which reports the Mudlet application's idea of its current working directory and the location(s) from which it would look to find binary libraries. #### Motivation for adding to Mudlet A user was reporting issues where Mudlet would load their first profile, including loading all the Lua binary libraries (such as the Lua File System) one and then fail to find it for a second profile, given that in their case (Windows 64 bit) release version this would be from the same directory as the Mudlet executable itself (the `./lfs.dll` entry reported) in the error message in the main console. This function is intended to enable the "current" working directory to be monitored - so that if it gets changed it can be detected. #### Other info (issues closed, discussion etc) **This is a test/draft PR - it is not intended to be merged into the main code-base.** The user concerned with whom I have been helping with this is the Discord user `kyrus78`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Adds
applicationPaths()function to Lua API which reports the Mudlet application's idea of its current working directory and the location(s) from which it would look to find binary libraries.Motivation for adding to Mudlet
A user was reporting issues where Mudlet would load their first profile, including loading all the Lua binary libraries (such as the Lua File System) one and then fail to find it for a second profile, given that in their case (Windows 64 bit) release version this would be from the same directory as the Mudlet executable itself (the
./lfs.dllentry reported) in the error message in the main console. This function is intended to enable the "current" working directory to be monitored - so that if it gets changed it can be detected.Other info (issues closed, discussion etc)
This is a test/draft PR - it is not intended to be merged into the main code-base. The user concerned with whom I have been helping with this is the Discord user
kyrus78.