-
-
Notifications
You must be signed in to change notification settings - Fork 294
Fix: switch to linuxdeploy #7806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
#### Brief overview of PR changes/additions Revises the Linux CI/CB process to use [`linuxdeploy`](https://github.com/linuxdeploy/linuxdeploy) instead of `linuxdeployqt`. #### Motivation for adding to Mudlet `linuxdeployqt` won't work next week as GitHub are removing the Ubuntu 20.04 runner and that tool will not work with the later `22.04` one until the maintainer updates it to do so (the CRT is too new). #### Other info (issues closed, discussion etc) The maintainer of linuxdeployqt is refusing to updating to Ubuntu 22.04 until it officially reaches EOL (in a month or so) but GitHub will not provide Ubuntu 20.04 from 2025/04/15 and has been "browning it out intermittently for the past few months. This also switches the Linux run that is used for deployment to Ubuntu 22.04 it remains to be seen whether this is still usable for the oldest versions of the Linux OS which we provide AppImages for. Some variables in the `bash` scripts used for Linux CI that were not have been made SCREAMING_SNAKE_CASE so that they can be picked out better. Some issues that [ShellCheck](https://www.shellcheck.net/) highlighted have been "fixed" as well. THIS IS A DRAFT CURRENTLY AS IT USES A PR FROM THE **INSTALLERS** REPO. It can not be merged until that PR is debugged and merged into that repository. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
|
…eneration Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
So switch to later GCC as before AND later Ubuntu 22.04. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
…ller.sh Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
…update Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
…let.yml Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Also try and cause a new build to be done as GH Actions are currently suffering problems according to status report. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Also add conditional qDebug() messages for the loading of translations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
…er case Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Conflicts resolved in: * .github/workflows/build-mudlet.yml Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
…runner Also trigger a rebuild to use an update to the installer repo branch in use so that it includes code to support older CRTs when the AppImage is used. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
So that it pulls in a change to the installer repository... Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Using a later one might be the reason I couldn't get the AppImage to run on Devuan 4.0 "Chimaera" even with using the `checkrt` plugin for `linuxdeploy`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
#### Brief overview of PR changes/additions Change the Linux Ci/CB runner used to make the AppImage for that OS from the Ubuntu 20.04 LTS one to the 22.04 one. #### Motivation for adding to Mudlet This is unavoidable because the older one is being removed tomorrow. #### Other info (issues closed, discussion etc) Because of some intransigence by the maintainer of the `linuxdeployqt` tool we use to make the AppImage it is not being updated to work with the 22.04 one until that reached its official EOL next month. This seems to mean that the AppImages produced in the newer runner will NOT work on systems with the older `libc` that was used in the 20.04 version and others such as Debian 11 ("Bullseye") and Devuan 4 ("Chimaera"). I have been trying to find a solution but have not got a workable one yet. (See: Mudlet#7806 and Mudlet/installers#123). Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Debian 12. Geyser seems to be acting funny. My other Geyser profiles were affected too, mostly missing windows and decoration. Then stumbled across this error about AdjustableContainers. Reproducable with; No icons in right-click menu, can't manipulate window. |
@ZookaOnGit thanks for that error report - that is the sort of detail this needs. Which locale have you set your GUI to - is it the (default) en_US - The reason for this is that I note that if I expand the contents of the AppImage (with A quick fix to confirm that this is the problem would be to copy the It seems we hit the same issue in the past with Windows builds (see #7242!) |
This might be important if the Qt5 and Qt6 ones are different! This is actually needed to prompt a rebuild with a revised PR in the installer repository. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Also report the lrelease tool version when it is run by CMake - unlike the prior commit that only did it for QMake. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Brief overview of PR changes/additions
Revises the Linux CI/CB process to use
linuxdeploy
instead oflinuxdeployqt
.Motivation for adding to Mudlet
linuxdeployqt
won't work next week as GitHub are removing the Ubuntu 20.04 runner and that tool will not work with the later22.04
one until the maintainer updates it to do so (the CRT is too new).Other info (issues closed, discussion etc)
The maintainer of linuxdeployqt is refusing to updating to Ubuntu 22.04 until it officially reaches EOL (in a month or so) but GitHub will not provide Ubuntu 20.04 from 2025/04/15 and has been "browning it out intermittently for the past few months.
This also switches the Linux run that is used for deployment to Ubuntu 22.04 it remains to be seen whether this is still usable for the oldest versions of the Linux OS which we provide AppImages for.
Some variables in the
bash
scripts used for Linux CI that were not have been made SCREAMING_SNAKE_CASE so that they can be picked out better.Some issues that ShellCheck highlighted have been "fixed" as well.
THIS IS A DRAFT CURRENTLY AS IT USES A PR FROM THE INSTALLERS REPO. It can not be merged until that PR is debugged and merged into that repository.