chore(deps): bump yargs and typescript (#5629)

farfromrefug · web-flow · commit 81ed843a3172 · 2022-02-15T14:20:23.000+01:00
diff --git a/lib/common/file-system.ts b/lib/common/file-system.ts
@@ -174,7 +174,7 @@ export class FileSystem implements IFileSystem {
 	}
 
 	public async futureFromEvent(eventEmitter: any, event: string): Promise<any> {
-		return new Promise((resolve, reject) => {
+		return new Promise<any>((resolve, reject) => {
 			eventEmitter.once(event, function () {
 				const args = _.toArray(arguments);
 
@@ -186,7 +186,7 @@ export class FileSystem implements IFileSystem {
 
 				switch (args.length) {
 					case 0:
-						resolve();
+						resolve(undefined);
 						break;
 					case 1:
 						resolve(args[0]);
diff --git a/lib/common/helpers.ts b/lib/common/helpers.ts
@@ -198,7 +198,7 @@ export function settlePromises<T>(promises: Promise<T>[]): Promise<T[]> {
 		const length = promises.length;
 
 		if (!promises.length) {
-			resolve();
+			resolve(null);
 		}
 
 		_.forEach(promises, (currentPromise, index) => {
@@ -491,7 +491,7 @@ export async function getFuturesResults<T>(
 ): Promise<T[] | T[][]> {
 	const results = await Promise.all(promises);
 
-	return _(results).filter(predicate).flatten().value();
+	return _(results).filter(predicate).flatten().value() as T[] | T[][];
 }
 
 /**
diff --git a/lib/common/mobile/application-manager-base.ts b/lib/common/mobile/application-manager-base.ts
@@ -117,25 +117,25 @@ export abstract class ApplicationManagerBase
 		}
 	}
 
-	public abstract async installApplication(
+	public abstract installApplication(
 		packageFilePath: string,
 		appIdentifier?: string,
 		buildData?: IBuildData
 	): Promise<void>;
-	public abstract async uninstallApplication(
+	public abstract uninstallApplication(
 		appIdentifier: string
 	): Promise<void>;
-	public abstract async startApplication(
+	public abstract startApplication(
 		appData: Mobile.IApplicationData
 	): Promise<void>;
-	public abstract async stopApplication(
+	public abstract stopApplication(
 		appData: Mobile.IApplicationData
 	): Promise<void>;
-	public abstract async getInstalledApplications(): Promise<string[]>;
-	public abstract async getDebuggableApps(): Promise<
+	public abstract getInstalledApplications(): Promise<string[]>;
+	public abstract getDebuggableApps(): Promise<
 		Mobile.IDeviceApplicationInformation[]
 	>;
-	public abstract async getDebuggableAppViews(
+	public abstract getDebuggableAppViews(
 		appIdentifiers: string[]
 	): Promise<IDictionary<Mobile.IDebugWebViewInfo[]>>;
 
diff --git a/lib/common/mobile/ios/device/ios-device-operations.ts b/lib/common/mobile/ios/device/ios-device-operations.ts
@@ -84,7 +84,7 @@ export class IOSDeviceOperations
 			}
 
 			// We need this because we need to make sure that we have devices.
-			await new Promise((resolve, reject) => {
+			await new Promise<void>((resolve, reject) => {
 				let iterationsCount = 0;
 				const maxIterationsCount = 3;
 
diff --git a/lib/common/mobile/ios/ios-device-base.ts b/lib/common/mobile/ios/ios-device-base.ts
@@ -57,7 +57,7 @@ export abstract class IOSDeviceBase implements Mobile.IiOSDevice {
 		}, `ios-debug-socket-${this.deviceInfo.identifier}-${appId}.lock`);
 	}
 
-	protected abstract async getDebugSocketCore(
+	protected abstract getDebugSocketCore(
 		appId: string
 	): Promise<net.Socket>;
 
diff --git a/lib/common/test/unit-tests/helpers.ts b/lib/common/test/unit-tests/helpers.ts
@@ -99,7 +99,7 @@ describe("helpers", () => {
 			element: any,
 			passedChunkSize: number
 		) => {
-			return new Promise((resolve) =>
+			return new Promise<void>((resolve) =>
 				setImmediate(() => {
 					const remainingElements = _.difference(
 						initialDataValues,
diff --git a/lib/common/test/unit-tests/mobile/devices-service.ts b/lib/common/test/unit-tests/mobile/devices-service.ts
@@ -300,7 +300,7 @@ function resetDefaultSetInterval(): void {
 }
 
 async function assertOnNextTick(assertionFunction: Function): Promise<void> {
-	await new Promise((resolve) => {
+	await new Promise<void>((resolve) => {
 		setTimeout(() => {
 			assertionFunction();
 			resolve();
diff --git a/lib/options.ts b/lib/options.ts
@@ -1,5 +1,6 @@
 import * as helpers from "./common/helpers";
-import * as yargs from "yargs";
+import * as yargs from 'yargs';
+import { hideBin } from 'yargs/helpers';
 import * as _ from "lodash";
 import {
 	IDictionary,
@@ -366,9 +367,9 @@ export class Options {
 			opts[this.getDashedOptionName(key)] = value;
 		});
 
-		const parsed = yargs(process.argv.slice(2)).version(false).help(false);
-		this.initialArgv = parsed.argv;
-		this.argv = parsed.options(<any>opts).argv;
+		const parsed = yargs(hideBin(process.argv)).version(false).help(false);
+		this.initialArgv = parsed.argv as any;
+		this.argv = parsed.options(<any>opts).argv as any;
 
 		// For backwards compatibility
 		// Previously profileDir had a default option and calling `this.$options.profileDir` always returned valid result.
diff --git a/lib/services/debug-service-base.ts b/lib/services/debug-service-base.ts
@@ -18,12 +18,12 @@ export abstract class DebugServiceBase
 
 	public abstract get platform(): string;
 
-	public abstract async debug(
+	public abstract debug(
 		debugData: IDebugData,
 		debugOptions: IDebugOptions
 	): Promise<IDebugResultInfo>;
 
-	public abstract async debugStop(): Promise<void>;
+	public abstract debugStop(): Promise<void>;
 
 	protected getCanExecuteAction(
 		deviceIdentifier: string
diff --git a/lib/services/livesync/android-device-livesync-service-base.ts b/lib/services/livesync/android-device-livesync-service-base.ts
@@ -17,11 +17,11 @@ export abstract class AndroidDeviceLiveSyncServiceBase extends DeviceLiveSyncSer
 		super($platformsDataService, device);
 	}
 
-	public abstract async transferFilesOnDevice(
+	public abstract transferFilesOnDevice(
 		deviceAppData: Mobile.IDeviceAppData,
 		localToDevicePaths: Mobile.ILocalToDevicePathData[]
 	): Promise<void>;
-	public abstract async transferDirectoryOnDevice(
+	public abstract transferDirectoryOnDevice(
 		deviceAppData: Mobile.IDeviceAppData,
 		localToDevicePaths: Mobile.ILocalToDevicePathData[],
 		projectFilesPath: string
diff --git a/lib/services/livesync/android-livesync-tool.ts b/lib/services/livesync/android-livesync-tool.ts
@@ -292,7 +292,7 @@ export class AndroidLivesyncTool implements IAndroidLivesyncTool {
 		await this.writeToSocket(hash);
 	}
 
-	private sendFileContent(filePath: string): Promise<boolean> {
+	private sendFileContent(filePath: string): Promise<void> {
 		return new Promise((resolve, reject) => {
 			if (!this.verifyActiveConnection(reject)) {
 				return;
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ export function settlePromises<T>(promises: Promise<T>[]): Promise<T[]> {`
`198`	`198`	`const length = promises.length;`
`199`	`199`
`200`	`200`	`if (!promises.length) {`
`201`		`- resolve();`
	`201`	`+ resolve(null);`
`202`	`202`	`}`
`203`	`203`
`204`	`204`	`_.forEach(promises, (currentPromise, index) => {`
`@@ -491,7 +491,7 @@ export async function getFuturesResults<T>(`
`491`	`491`	`): Promise<T[] \| T[][]> {`
`492`	`492`	`const results = await Promise.all(promises);`
`493`	`493`
`494`		`- return _(results).filter(predicate).flatten().value();`
	`494`	`+ return _(results).filter(predicate).flatten().value() as T[] \| T[][];`
`495`	`495`	`}`
`496`	`496`
`497`	`497`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ export class IOSDeviceOperations`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`// We need this because we need to make sure that we have devices.`
`87`		`- await new Promise((resolve, reject) => {`
	`87`	`+ await new Promise<void>((resolve, reject) => {`
`88`	`88`	`let iterationsCount = 0;`
`89`	`89`	`const maxIterationsCount = 3;`
`90`	`90`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ export abstract class IOSDeviceBase implements Mobile.IiOSDevice {`
`57`	`57`	}, `ios-debug-socket-${this.deviceInfo.identifier}-${appId}.lock`);
`58`	`58`	`}`
`59`	`59`
`60`		`- protected abstract async getDebugSocketCore(`
	`60`	`+ protected abstract getDebugSocketCore(`
`61`	`61`	`appId: string`
`62`	`62`	`): Promise<net.Socket>;`
`63`	`63`
Original file line number	Diff line number	Diff line change
`@@ -300,7 +300,7 @@ function resetDefaultSetInterval(): void {`
`300`	`300`	`}`
`301`	`301`
`302`	`302`	`async function assertOnNextTick(assertionFunction: Function): Promise<void> {`
`303`		`- await new Promise((resolve) => {`
	`303`	`+ await new Promise<void>((resolve) => {`
`304`	`304`	`setTimeout(() => {`
`305`	`305`	`assertionFunction();`
`306`	`306`	`resolve();`