fix(google-signin ios): define serverClientId as optional parameter in Configuration-interface and do not overwrite clientId variable when serverClientId-parameter is provided in options (#292)

felixkrautschuk · web-flow · commit d6df8446a3ca · 2022-06-29T08:03:41.000-04:00
diff --git a/packages/google-signin/common.ts b/packages/google-signin/common.ts
@@ -4,6 +4,7 @@ export interface Configuration {
 	scopes?: string[];
 	signInOptions?: 'default' | 'games';
 	clientId?: string;
+	serverClientId?: string;
 	accountName?: string;
 	hostedDomain?: string;
 }
diff --git a/packages/google-signin/index.ios.ts b/packages/google-signin/index.ios.ts
@@ -124,7 +124,7 @@ export class GoogleSignin {
 
 			let serverClientId;
 			if (configuration['serverClientId']) {
-				clientId = configuration['serverClientId'];
+				serverClientId = configuration['serverClientId'];
 			} else {
 				if (!plist) {
 					plist = NSDictionary.alloc().initWithContentsOfFile(path);

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ export interface Configuration {`
`4`	`4`	`scopes?: string[];`
`5`	`5`	`signInOptions?: 'default' \| 'games';`
`6`	`6`	`clientId?: string;`
	`7`	`+ serverClientId?: string;`
`7`	`8`	`accountName?: string;`
`8`	`9`	`hostedDomain?: string;`
`9`	`10`	`}`