From 98af1e334a08fda095d2e797717879aa65de0f52 Mon Sep 17 00:00:00 2001 From: Nathan Walker Date: Mon, 10 Jul 2023 13:46:55 -0700 Subject: [PATCH 01/14] fix(geolocation): perm handling around wheninuse vs always closes https://github.com/NativeScript/plugins/issues/386 --- packages/geolocation/index.ios.ts | 2 +- packages/geolocation/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/geolocation/index.ios.ts b/packages/geolocation/index.ios.ts index f9f31975..40a8ed52 100644 --- a/packages/geolocation/index.ios.ts +++ b/packages/geolocation/index.ios.ts @@ -109,7 +109,7 @@ class LocationListenerImpl extends NSObject implements CLLocationManagerDelegate } break; case CLAuthorizationStatus.kCLAuthorizationStatusAuthorizedWhenInUse: - if (this._resolve && !this.authorizeAlways) { + if (this._resolve) { LocationMonitor.stopLocationMonitoring(this.id); this._resolve(); } diff --git a/packages/geolocation/package.json b/packages/geolocation/package.json index 47496476..8fe4458f 100644 --- a/packages/geolocation/package.json +++ b/packages/geolocation/package.json @@ -1,6 +1,6 @@ { "name": "@nativescript/geolocation", - "version": "8.2.0", + "version": "8.2.1-beta.0", "description": "Provides API for getting and monitoring location for NativeScript app.", "main": "index", "typings": "index.d.ts", From 01aaec8df236c9ea7fa44bf84f06740178ba5e95 Mon Sep 17 00:00:00 2001 From: Nathan Walker Date: Tue, 11 Jul 2023 14:52:31 -0700 Subject: [PATCH 02/14] chore: cleanup --- apps/demo-angular/project.json | 16 ++++++---------- apps/demo/project.json | 16 ++++++---------- apps/demo/src/main-page.xml | 5 +---- 3 files changed, 13 insertions(+), 24 deletions(-) diff --git a/apps/demo-angular/project.json b/apps/demo-angular/project.json index 57eebe49..70452a08 100644 --- a/apps/demo-angular/project.json +++ b/apps/demo-angular/project.json @@ -21,10 +21,9 @@ } ] }, - "ios": { - "executor": "@nativescript/nx:build", + "debug": { + "executor": "@nativescript/nx:debug", "options": { - "platform": "ios", "noHmr": true }, "dependsOn": [ @@ -34,10 +33,9 @@ } ] }, - "android": { - "executor": "@nativescript/nx:build", + "prepare": { + "executor": "@nativescript/nx:prepare", "options": { - "platform": "android", "noHmr": true }, "dependsOn": [ @@ -48,10 +46,8 @@ ] }, "clean": { - "executor": "@nativescript/nx:build", - "options": { - "clean": true - } + "executor": "@nativescript/nx:clean", + "options": {} }, "lint": { "executor": "@nx/linter:eslint", diff --git a/apps/demo/project.json b/apps/demo/project.json index 55887d78..75cce95b 100644 --- a/apps/demo/project.json +++ b/apps/demo/project.json @@ -21,10 +21,9 @@ } ] }, - "ios": { - "executor": "@nativescript/nx:build", + "debug": { + "executor": "@nativescript/nx:debug", "options": { - "platform": "ios", "noHmr": true }, "dependsOn": [ @@ -34,10 +33,9 @@ } ] }, - "android": { - "executor": "@nativescript/nx:build", + "prepare": { + "executor": "@nativescript/nx:prepare", "options": { - "platform": "android", "noHmr": true }, "dependsOn": [ @@ -48,10 +46,8 @@ ] }, "clean": { - "executor": "@nativescript/nx:build", - "options": { - "clean": true - } + "executor": "@nativescript/nx:clean", + "options": {} }, "lint": { "executor": "@nx/linter:eslint", diff --git a/apps/demo/src/main-page.xml b/apps/demo/src/main-page.xml index 3f2c4c7d..4e542f5f 100644 --- a/apps/demo/src/main-page.xml +++ b/apps/demo/src/main-page.xml @@ -27,21 +27,18 @@