Core: removed aria-required attribute (jquery-validation#2012)

alexbokii · Arkni · commit 54073af10988 · 2017-06-12T15:50:57.000Z
Fixes jquery-validation#1841
diff --git a/src/core.js b/src/core.js
@@ -158,9 +158,6 @@ $.extend( $.fn, {
 				$.each( argument.split( /\s/ ), function( index, method ) {
 					filtered[ method ] = existingRules[ method ];
 					delete existingRules[ method ];
-					if ( method === "required" ) {
-						$( element ).removeAttr( "aria-required" );
-					}
 				} );
 				return filtered;
 			}
@@ -180,7 +177,6 @@ $.extend( $.fn, {
 			param = data.required;
 			delete data.required;
 			data = $.extend( { required: param }, data );
-			$( element ).attr( "aria-required", "true" );
 		}
 
 		// Make sure remote is at back
@@ -418,10 +414,6 @@ $.extend( $.validator, {
 			if ( this.settings.invalidHandler ) {
 				$( this.currentForm ).on( "invalid-form.validate", this.settings.invalidHandler );
 			}
-
-			// Add aria-required to any Static/Data/Class required fields before first validation
-			// Screen readers require this attribute to be present before the initial submission https://www.w3.org/TR/WCAG-TECHS/ARIA2.html
-			$( this.currentForm ).find( "[required], [data-rule-required], .required" ).attr( "aria-required", "true" );
 		},
 
 		// https://jqueryvalidation.org/Validator.form/
diff --git a/test/aria.js b/test/aria.js
@@ -44,40 +44,3 @@ QUnit.test( "resetForm(): removes all aria-invalid attributes", function( assert
 	assert.equal( $( "#ariaInvalid [aria-invalid]" ).length, 0, "resetForm() should remove any aria-invalid attributes" );
 } );
 
-QUnit.test( "Static required field adds aria-required", function( assert ) {
-	var ariaRequiredStatic = $( "#ariaRequiredStatic" ),
-		form = $( "#ariaRequired" );
-
-	form.validate();
-	assert.equal( ariaRequiredStatic.attr( "aria-required" ), "true" );
-} );
-
-QUnit.test( "Data required field adds aria-required", function( assert ) {
-	var ariaRequiredData = $( "#ariaRequiredData" ),
-		form = $( "#ariaRequired" );
-
-	form.validate();
-	assert.equal( ariaRequiredData.attr( "aria-required" ), "true" );
-} );
-
-QUnit.test( "Class required field adds aria-required", function( assert ) {
-	var ariaRequiredClass = $( "#ariaRequiredClass" ),
-		form = $( "#ariaRequired" );
-
-	form.validate();
-	assert.equal( ariaRequiredClass.attr( "aria-required" ), "true" );
-} );
-
-QUnit.test( "Dynamically required field adds aria-required after valid()", function( assert ) {
-	var ariaRequiredDynamic = $( "#ariaRequiredDynamic" ),
-		form = $( "#ariaRequired" );
-
-	form.resetForm();
-	form.validate( {
-		rules: {
-			ariaRequiredDynamic: "required"
-		}
-	} );
-	ariaRequiredDynamic.valid();
-	assert.equal( ariaRequiredDynamic.attr( "aria-required" ), "true" );
-} );
