Skip to content

Commit f3d6f81

Browse files
authored
fix: CMake example commands in README.md
The format of `target_include_directories` has changed in the recent CMake versions (3.5 and higher) 'target_link_libraries' had a typo Minor fix: "apt-get" is generally preferred over aptitude for Ubuntu Thank you!
1 parent 5b1c7bb commit f3d6f81

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ matplotlib-cpp works by wrapping the popular python plotting library matplotlib.
9898
This means you have to have a working python installation, including development headers.
9999
On Ubuntu:
100100

101-
sudo aptitude install python-matplotlib python-numpy python2.7-dev
101+
sudo apt-get install python-matplotlib python-numpy python2.7-dev
102102

103103
If, for some reason, you're unable to get a working installation of numpy on your system,
104104
you can add the define `WITHOUT_NUMPY` to erase this dependency.
@@ -115,8 +115,8 @@ If you prefer to use CMake as build system, you will want to add something like
115115
CMakeLists.txt:
116116

117117
find_package(PythonLibs 2.7)
118-
target_include_directories(myproject ${PYTHON_INCLUDE_DIRS})
119-
target_link_libraries(myproject ${PYTHON_LIBRARIES)
118+
target_include_directories(myproject PRIVATE ${PYTHON_INCLUDE_DIRS})
119+
target_link_libraries(myproject ${PYTHON_LIBRARIES})
120120

121121
# Python 3
122122

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy