Fix detect Vue3 defineComponent (vuejs#1088)

yoyo930021 · ota-meshi · web-flow · commit cadec3b1c804 · 2020-04-21T17:11:32.000+09:00
Co-authored-by: Yosuke Ota &lt;otameshiyo23@gmail.com&gt;
diff --git a/lib/utils/index.js b/lib/utils/index.js
@@ -550,6 +550,12 @@ module.exports = {
           const isAppVueComponent = isObjectArgument(node)
           return isAppVueComponent
         }
+        if (callee.name === 'defineComponent') {
+          // for Vue.js 3.x
+          // defineComponent({})
+          const isDestructedVueComponent = isObjectArgument(node)
+          return isDestructedVueComponent
+        }
       }
     }
 
diff --git a/tests/lib/rules/no-dupe-keys.js b/tests/lib/rules/no-dupe-keys.js
@@ -639,6 +639,44 @@ ruleTester.run('no-dupe-keys', rule, {
         message: 'Duplicated key \'foo\'.',
         line: 9
       }]
+    },
+    {
+      filename: 'test.js',
+      code: `
+        defineComponent({
+          foo: {
+            bar: String
+          },
+          data: {
+            bar: null
+          },
+        })
+      `,
+      options: [{ groups: ['foo'] }],
+      parserOptions: { ecmaVersion: 6 },
+      errors: [{
+        message: 'Duplicated key \'bar\'.',
+        line: 7
+      }]
+    },
+    {
+      filename: 'test.js',
+      code: `
+        export default defineComponent({
+          foo: {
+            bar: String
+          },
+          data: {
+            bar: null
+          },
+        })
+      `,
+      options: [{ groups: ['foo'] }],
+      parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+      errors: [{
+        message: 'Duplicated key \'bar\'.',
+        line: 7
+      }]
     }
   ]
 })
diff --git a/tests/lib/utils/vue-component.js b/tests/lib/utils/vue-component.js
@@ -311,6 +311,12 @@ function invalidTests (ext) {
       `,
       parserOptions,
       errors: (ext === 'js' ? [] : [makeError(2)]).concat([makeError(8)])
+    },
+    {
+      filename: `test.${ext}`,
+      code: `export default defineComponent({})`,
+      parserOptions,
+      errors: [makeError(1)]
     }
   ]
 }

Original file line number	Diff line number	Diff line change
`@@ -550,6 +550,12 @@ module.exports = {`
`550`	`550`	`const isAppVueComponent = isObjectArgument(node)`
`551`	`551`	`return isAppVueComponent`
`552`	`552`	`}`
	`553`	`+ if (callee.name === 'defineComponent') {`
	`554`	`+ // for Vue.js 3.x`
	`555`	`+ // defineComponent({})`
	`556`	`+ const isDestructedVueComponent = isObjectArgument(node)`
	`557`	`+ return isDestructedVueComponent`
	`558`	`+ }`
`553`	`559`	`}`
`554`	`560`	`}`
`555`	`561`
Original file line number	Diff line number	Diff line change
`@@ -311,6 +311,12 @@ function invalidTests (ext) {`
`311`	`311`	`,
`312`	`312`	`parserOptions,`
`313`	`313`	`errors: (ext === 'js' ? [] : [makeError(2)]).concat([makeError(8)])`
	`314`	`+ },`
	`315`	`+ {`
	`316`	+ filename: `test.${ext}`,
	`317`	+ code: `export default defineComponent({})`,
	`318`	`+ parserOptions,`
	`319`	`+ errors: [makeError(1)]`
`314`	`320`	`}`
`315`	`321`	`]`
`316`	`322`	`}`