fix(dts-generator): in function typedefs, parse types properly (#508)

akudev · web-flow · commit 06e6c57417e5 · 2025-06-24T10:39:32.000+02:00
diff --git a/packages/dts-generator/src/phases/json-fixer.ts b/packages/dts-generator/src/phases/json-fixer.ts
@@ -647,9 +647,7 @@ function parseTypeExpressions(symbols: ConcreteSymbol[]) {
       visitAnythingWithAType(typedef.returnValue);
     }
     if (typedef.parameters) {
-      typedef.parameters.forEach((param) => {
-        visitAnythingWithAType(param);
-      });
+      typedef.parameters.forEach(visitParam);
     }
   }
 
diff --git a/packages/dts-generator/src/phases/json-to-ast.ts b/packages/dts-generator/src/phases/json-to-ast.ts
@@ -1840,16 +1840,7 @@ function buildTypedef(ui5Typedef: TypedefSymbol): TypeAliasDeclaration {
   } else if (ui5Typedef.returnValue || _.isArray(ui5Typedef.parameters)) {
     type = {
       kind: "FunctionType",
-      parameters: _.map(
-        ui5Typedef.parameters,
-        (param) =>
-          ({
-            kind: "Parameter",
-            name: param.name,
-            type: param.type,
-            // TODO how to represent parameter documentation?
-          }) as Parameter,
-      ),
+      parameters: _.map(ui5Typedef.parameters, buildParameter),
     };
     if (ui5Typedef.returnValue) {
       type.type = ui5Typedef.returnValue.type; // NOTE: this .type is always an object in the debugger

Original file line number	Diff line number	Diff line change
`@@ -647,9 +647,7 @@ function parseTypeExpressions(symbols: ConcreteSymbol[]) {`
`647`	`647`	`visitAnythingWithAType(typedef.returnValue);`
`648`	`648`	`}`
`649`	`649`	`if (typedef.parameters) {`
`650`		`- typedef.parameters.forEach((param) => {`
`651`		`- visitAnythingWithAType(param);`
`652`		`- });`
	`650`	`+ typedef.parameters.forEach(visitParam);`
`653`	`651`	`}`
`654`	`652`	`}`
`655`	`653`