FIX: Pen touch input triggers UI/Click action two times (ISXB-1456) #2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2201 +/- ##
===========================================
- Coverage 68.10% 68.10% -0.01%
===========================================
Files 367 367
Lines 53610 53601 -9
===========================================
- Hits 36513 36504 -9
Misses 17097 17097
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where pen/touch input could generate duplicate UI/click actions by simplifying pointer cleanup logic and enhancing the UI pointer integration tests.
- Removed special-case handling that delayed touch-pointer removal by one frame
- Simplified
FilterPointerStatesByTypeto only remove non–mouse/pen pointers - Expanded UI tests to cover simultaneous mouse and touch input and ensure single-click behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Packages/com.unity.inputsystem/InputSystem/Plugins/UI/InputSystemUIInputModule.cs | Commented out touch-delay block and changed pointer-filter condition |
| Assets/Tests/InputSystem/Plugins/UITests.cs | Added new test scenario for concurrent mouse and touch clicks |
Comments suppressed due to low confidence (2)
Packages/com.unity.inputsystem/InputSystem/Plugins/UI/InputSystemUIInputModule.cs:2365
- This simplified condition now removes touch pointers immediately, which may contradict the intended one-frame delay for touch cleanup. Verify that touch removal timing still matches expected input behavior and adjust the condition to retain touch pointers when needed.
if (m_PointerStates[i].pointerType != UIPointerType.MouseOrPen)
Assets/Tests/InputSystem/Plugins/UITests.cs:1464
- The test calls
EndTouchon ID 1, but no touch with ID 1 was started here. This mismatch may prevent proper cleanup of the previous touch and lead to false positives. EnsureEndTouchuses the same touch ID as the correspondingBeginTouch.
EndTouch(1, secondPosition, screen: touch1);
Comment on lines
+2075
to
+2081
| // // We don't want to release touch pointers on the same frame they are released (unpressed). They get cleaned up one frame later in Process() | ||
| // ref var state = ref GetPointerStateForIndex(index); | ||
| // if (state.pointerType == UIPointerType.Touch && (state.leftButton.isPressed || state.leftButton.wasReleasedThisFrame)) | ||
| // { | ||
| // // The pointer was not removed | ||
| // return false; | ||
| // } |
There was a problem hiding this comment.
[nitpick] The double-commented block clutters the cleanup logic. Consider removing these dead code lines or extracting them behind a clearly named feature flag to improve readability.
Suggested change
| // // We don't want to release touch pointers on the same frame they are released (unpressed). They get cleaned up one frame later in Process() | |
| // ref var state = ref GetPointerStateForIndex(index); | |
| // if (state.pointerType == UIPointerType.Touch && (state.leftButton.isPressed || state.leftButton.wasReleasedThisFrame)) | |
| // { | |
| // // The pointer was not removed | |
| // return false; | |
| // } | |
| // Removed dead code block for clarity and readability. |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
This will be removed, it's just to help with testing at the moment.
fb31fe7 to
96b6291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please fill this section with a description what the pull request is trying to address and what changes were made.
Testing status & QA
Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: