trackable: Make move operations noexcept.

murraycu · murraycu · commit 4824bb537db4 · 2017-07-21T08:20:58.000+02:00
I don't think there is any reason not to.
Noticed by clang-tidy.
diff --git a/sigc++/trackable.cc b/sigc++/trackable.cc
@@ -38,7 +38,8 @@ trackable::trackable(const trackable& /*src*/) noexcept : callback_list_(nullptr
 //
 // If trackable's move constructor is modified, check if Glib::Object's
 // move constructor should be modified similarly.
-trackable::trackable(trackable&& src) : callback_list_(nullptr)
+trackable::trackable(trackable&& src) noexcept
+: callback_list_(nullptr)
 {
   src.notify_callbacks();
 }
@@ -53,7 +54,7 @@ trackable::operator=(const trackable& src)
 }
 
 trackable&
-trackable::operator=(trackable&& src)
+trackable::operator=(trackable&& src) noexcept
 {
   if (this != &src)
   {
diff --git a/sigc++/trackable.h b/sigc++/trackable.h
@@ -125,11 +125,11 @@ struct SIGC_API trackable : public notifiable
 
   trackable(const trackable& src) noexcept;
 
-  trackable(trackable&& src);
+  trackable(trackable&& src) noexcept;
 
   trackable& operator=(const trackable& src);
 
-  trackable& operator=(trackable&& src);
+  trackable& operator=(trackable&& src) noexcept;
 
   ~trackable();
 
diff --git a/tests/test_trackable_move.cc b/tests/test_trackable_move.cc
@@ -18,7 +18,10 @@ class my_class : public sigc::trackable
   my_class(const my_class& src) = delete;
   my_class& operator=(const my_class& src) = delete;
 
-  my_class(my_class&& src) : sigc::trackable(std::move(src)), i(std::move(src.i)) { src.i = 0; }
+  my_class(my_class&& src) noexcept
+  : sigc::trackable(std::move(src)), i(std::move(src.i)) {
+    src.i = 0;
+  }
 
   my_class& operator=(my_class&& src)
   {

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,8 @@ trackable::trackable(const trackable& /src/) noexcept : callback_list_(nullptr`
`38`	`38`	`//`
`39`	`39`	`// If trackable's move constructor is modified, check if Glib::Object's`
`40`	`40`	`// move constructor should be modified similarly.`
`41`		`-trackable::trackable(trackable&& src) : callback_list_(nullptr)`
	`41`	`+trackable::trackable(trackable&& src) noexcept`
	`42`	`+: callback_list_(nullptr)`
`42`	`43`	`{`
`43`	`44`	`src.notify_callbacks();`
`44`	`45`	`}`
`@@ -53,7 +54,7 @@ trackable::operator=(const trackable& src)`
`53`	`54`	`}`
`54`	`55`
`55`	`56`	`trackable&`
`56`		`-trackable::operator=(trackable&& src)`
	`57`	`+trackable::operator=(trackable&& src) noexcept`
`57`	`58`	`{`
`58`	`59`	`if (this != &src)`
`59`	`60`	`{`