Skip to content

Commit 90770d0

Browse files
authored
feat: low view mystique bug fix: send mandatory params (#911)
Please ensure your pull request adheres to the following guidelines: - [ ] make sure to link the related issues in this description - [ ] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes - [ ] If data sources for any opportunity has been updated/added, please update the [wiki](https://wiki.corp.adobe.com/display/AEMSites/Data+Sources+for+Opportunities) for same opportunity. ## Related Issues Thanks for contributing!
1 parent 92e19b2 commit 90770d0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/forms-opportunities/oppty-handlers/low-views-handler.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ export default async function createLowViewsOpportunities(auditUrl, auditDataObj
101101
auditId: auditData.auditId,
102102
deliveryType: site.getDeliveryType(),
103103
time: new Date().toISOString(),
104-
url: opportunityData.data.form,
105104
data: {
105+
url: opportunityData.data.form,
106106
form_source: opportunityData.data.formsource,
107107
cta_text: '', // This will be available after merging the changes for scraping form CTA text
108108
cta_source: '', // This will be available after merging the changes for scraping form CTA text

test/audits/forms/oppty-handlers/low-views-oppoty-handler.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ describe('createLowFormViewsOpportunities handler method', () => {
8686
siteId: 'site-id',
8787
auditId: 'audit-id',
8888
deliveryType: 'eds',
89-
url: 'https://www.surest.com/existing-opportunity',
9089
data: {
90+
url: 'https://www.surest.com/existing-opportunity',
9191
form_source: '',
9292
cta_text: '',
9393
cta_source: '',
@@ -99,8 +99,8 @@ describe('createLowFormViewsOpportunities handler method', () => {
9999
actual.type === expectedMessage.type
100100
&& actual.siteId === expectedMessage.siteId
101101
&& actual.auditId === expectedMessage.auditId
102+
&& actual.data.url === expectedMessage.data.url
102103
&& actual.deliveryType === expectedMessage.deliveryType
103-
&& actual.url === expectedMessage.url
104104
&& actual.data.form_source === expectedMessage.data.form_source
105105
&& actual.data.cta_text === expectedMessage.data.cta_text
106106
&& actual.data.cta_source === expectedMessage.data.cta_source

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy