build: migrate forms to rules_js (#61535)

josephperrott · thePunderWoman · commit f6b4602e1e10 · 2025-05-21T09:16:06.000Z
Migrate forms to use ng_project and ts_project PR Close #61535
diff --git a/packages/forms/BUILD.bazel b/packages/forms/BUILD.bazel
@@ -1,19 +1,22 @@
-load("//tools:defaults.bzl", "api_golden_test", "api_golden_test_npm_package", "generate_api_docs", "ng_module", "ng_package")
+load("//tools:defaults.bzl", "api_golden_test", "api_golden_test_npm_package", "generate_api_docs", "ng_package")
+load("//tools:defaults2.bzl", "ng_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ng_module(
+ng_project(
     name = "forms",
     srcs = glob(
         [
             "*.ts",
             "src/**/*.ts",
         ],
     ),
-    deps = [
-        "//packages/core",
+    interop_deps = [
         "//packages/platform-browser",
-        "@npm//rxjs",
+    ],
+    deps = [
+        "//:node_modules/rxjs",
+        "//packages/core:core_rjs",
     ],
 )
 
diff --git a/packages/forms/test/BUILD.bazel b/packages/forms/test/BUILD.bazel
@@ -1,20 +1,23 @@
-load("//tools:defaults.bzl", "karma_web_test_suite", "ts_library", "zone_compatible_jasmine_node_test")
+load("//tools:defaults.bzl", "karma_web_test_suite", "zone_compatible_jasmine_node_test")
+load("//tools:defaults2.bzl", "ts_project")
 
-ts_library(
+ts_project(
     name = "test_lib",
     testonly = True,
     srcs = glob(["**/*.ts"]),
-    # Visible to //:saucelabs_unit_tests_poc target
-    visibility = ["//:__pkg__"],
-    deps = [
-        "//packages/common",
-        "//packages/core",
-        "//packages/core/testing",
-        "//packages/forms",
+    interop_deps = [
         "//packages/platform-browser",
         "//packages/platform-browser/testing",
         "//packages/private/testing",
-        "@npm//rxjs",
+    ],
+    # Visible to //:saucelabs_unit_tests_poc target
+    visibility = ["//:__pkg__"],
+    deps = [
+        "//:node_modules/rxjs",
+        "//packages/common:common_rjs",
+        "//packages/core:core_rjs",
+        "//packages/core/testing:testing_rjs",
+        "//packages/forms:forms_rjs",
     ],
 )
 
diff --git a/packages/forms/test/ng_control_status_spec.ts b/packages/forms/test/ng_control_status_spec.ts
@@ -6,10 +6,9 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {ChangeDetectionStrategy, Component} from '@angular/core';
+import {ChangeDetectionStrategy, Component, provideZonelessChangeDetection} from '@angular/core';
 import {FormControl, FormsModule, ReactiveFormsModule, Validators} from '../public_api';
 import {TestBed} from '@angular/core/testing';
-import {provideZonelessChangeDetection} from '@angular/core/src/change_detection/scheduling/zoneless_scheduling_impl';
 
 describe('status host binding classes', () => {
   beforeEach(() => {
diff --git a/packages/forms/test/reactive_integration_spec.ts b/packages/forms/test/reactive_integration_spec.ts
@@ -18,7 +18,7 @@ import {
   ViewChild,
 } from '@angular/core';
 import {ComponentFixture, fakeAsync, TestBed, tick} from '@angular/core/testing';
-import {By} from '@angular/platform-browser/src/dom/debug/by';
+import {By} from '@angular/platform-browser';
 import {dispatchEvent, isNode, sortedClassList} from '@angular/private/testing';
 import {expect} from '@angular/private/testing/matchers';
 import {merge, NEVER, Observable, of, Subject, Subscription, timer} from 'rxjs';
diff --git a/packages/forms/test/template_integration_spec.ts b/packages/forms/test/template_integration_spec.ts
@@ -25,7 +25,7 @@ import {
   NgModel,
   Validator,
 } from '../index';
-import {By} from '@angular/platform-browser/src/dom/debug/by';
+import {By} from '@angular/platform-browser';
 import {dispatchEvent, sortedClassList} from '@angular/private/testing';
 import {merge} from 'rxjs';
 
diff --git a/packages/forms/test/value_accessor_integration_spec.ts b/packages/forms/test/value_accessor_integration_spec.ts
@@ -32,7 +32,7 @@ import {
   ReactiveFormsModule,
   Validators,
 } from '../index';
-import {By} from '@angular/platform-browser/src/dom/debug/by';
+import {By} from '@angular/platform-browser';
 import {dispatchEvent, isNode} from '@angular/private/testing';
 
 describe('value accessors', () => {
diff --git a/packages/language-service/test/legacy/BUILD.bazel b/packages/language-service/test/legacy/BUILD.bazel
@@ -19,6 +19,7 @@ filegroup(
     srcs = [
         "//packages/common:common_rjs",
         "//packages/core:core_rjs",
+        "//packages/forms:forms_rjs",
     ],
     output_group = "types",
 )

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ filegroup(`
`19`	`19`	`srcs = [`
`20`	`20`	`"//packages/common:common_rjs",`
`21`	`21`	`"//packages/core:core_rjs",`
	`22`	`+ "//packages/forms:forms_rjs",`
`22`	`23`	`],`
`23`	`24`	`output_group = "types",`
`24`	`25`	`)`