-
Notifications
You must be signed in to change notification settings - Fork 974
POC: try using Arc<Vec<Buffer>> instead of Arc<[Buffer]> #7804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…rray` for faster `slice`
🤖 |
🤖: Benchmark completed Details
|
🤖 |
/// Convertes this ViewBuffers into a Vec<Buffer>, cloning the underlying buffers if | ||
/// they are shared. | ||
pub fn unwrap_or_clone(self) -> Vec<Buffer> { | ||
Arc::unwrap_or_clone(self.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is nice.
🤖: Benchmark completed Details
|
🤖 |
Weirdly this still shows a slow down for concat
🤔 |
🤖: Benchmark completed Details
|
🤖 |
🤖: Benchmark completed Details
|
This is an experiment built on top of @ctsk 's PR here: #7773
The idea is to just use the Vec directly rather than discarding the vec overhead. This change is in
I will run benchmarks against this PR and see how they look compared to